mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-26 16:45:57 +03:00
[GH-ISSUE #1697] Selection of multiple Apps and/or Domains should apply appropriate filtering to the requests view #1688
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#1688
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @seidnerj on GitHub (Jun 28, 2023).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1697
Originally assigned to: @NghiaTranUIT on GitHub.
Description
Right now, when one clicks any app/domain on the left hand side, the requests list is filtered accordingly. However, when selecting multiple apps and/or domains, the filtering applied is only for the last selected app/domain.
Why this feature/change is important?
The current behavior is confusing and counter-intuitive, especially given the single-selection behavior. I addition, it is very useful to be able to select multiple apps and/or domains and view the relevant requests list.
@jalmaas commented on GitHub (Jan 11, 2024):
Was going to post this as a bug because I thought it used to work how you describe wanted behaviour, but maybe it's been like this all along? Needless to say I agree that current behaviour is counter-intuitive and being able to select multiple apps and/or domains would be really nice!
@seidnerj commented on GitHub (Jan 11, 2024):
I think it's always been like this. Very counterintuitive. This combined with selection remaining when deleting a bunch of requests is definitely the top 2 most annoying things using Proxyman which is otherwise an amazing product.
@NghiaTranUIT commented on GitHub (Jan 11, 2024):
@seidnerj can you share with me the video or screenshot to show it ?
Currently, after deleting a list of selected requests in the main table -> The Selection is remained is correct behavior from macOS.
I'm not sure what you expect: Reset the index to 0 🤔
@NghiaTranUIT commented on GitHub (Jan 11, 2024):
it's not a bug. It's a limitation of the app.
We allow multiple selections, so we can delete many domains/apps easily. However, it doesn't combine all requests from these selected domains/apps.
@seidnerj commented on GitHub (Jan 11, 2024):
Attached a video below. The scenario is you select a bunch of requests, then delete them, but after the deletion the selection persists and now other requests are selected. This might make sense when you only selected a single request, the selection just moves to the next one that's available but when there are multiple requests - its confusing because you are now selecting a bunch of random requests. After deletion I would expect the selection to behave as follows:
Makes sense?
https://github.com/ProxymanApp/Proxyman/assets/4147381/3fb9e5fb-1f98-43e2-a934-923d57e5e01f
@seidnerj commented on GitHub (Jan 11, 2024):
It would be really useful if it does - the current behavior is confusing, you're selecting multiple things you can "act" on but in the requests view you are shown only requests relevant to one of the domains you selected and its not even clear to which domain these requests belong since the shown requests depends on the last click domain and so you essentially have a situation where the same domains are selected but different requests are shown see an example here:
@NghiaTranUIT commented on GitHub (Jan 12, 2024):
Thanks for the video. It makes sense now. I'm going to fix this 👍
@NghiaTranUIT commented on GitHub (Jan 12, 2024):
It's a known issue unfortunately, it's how we design the TreeNode. It doesn't enable to showing of multiple requests/responses when selecting multiple apps/domains.
@seidnerj commented on GitHub (Jan 12, 2024):
Thanks a lot!
@NghiaTranUIT commented on GitHub (Jan 12, 2024):
@seidnerj the selection after deleting issue is fixed now. You can use this Beta build: https://download.proxyman.io/beta/Proxyman_4.16.0_Fix_selection_after_deleting.dmg
Video
https://github.com/ProxymanApp/Proxyman/assets/5878421/05a5995c-8394-4ce7-a437-ed9771a4bacd
https://github.com/ProxymanApp/Proxyman/assets/5878421/2595f411-9124-4927-844f-f607c107d1b0
Please share with me your thought. I'm trying to mimic the same UX behavior of the Finder app.
@seidnerj commented on GitHub (Jan 12, 2024):
@NghiaTranUIT That's awesome!
In the case of non-consecutive requests, after deletion, the selection should be of the next available request after the last deleted request (not the first request, as is shown in the video you attached).
Also, note that if there if there no requests available appearing after the last deleted request then after deletion no request should be selected. This is consistent with the finder app (see attached video exhibiting this behavior).
https://github.com/ProxymanApp/Proxyman/assets/4147381/7752d1b7-527e-40df-bf02-a87733319bc4
@NghiaTranUIT commented on GitHub (Jan 12, 2024):
It's tedious to re-select (click) again to see the request-response.
I'm happy with the current change. It automatically selects the last row, so I can see the Request/Response immediately. No need to click again to see it.
@seidnerj commented on GitHub (Jan 12, 2024):
Sorry, I'm a bit confused - in the video you sent (1st video, second 9), it can be seen that after the deleting requests 2, 25 & 28 request 15 becomes selected, i.e. the first row, not the last row (which would be request 29 in this case)?
In general, I think an app should strive for "behavior" which is consistent with an end-user's expectation. I such a case, I believe the expectation is that it behaves the way other apps behave (e.g. Finder app etc.).