[GH-ISSUE #1590] "Unpin" implementation + change logic for "Delete" action for pinned items #1583

New issue

Open

opened 2026-03-03 19:52:39 +03:00 by kerem · 1 comment

kerem commented

2026-03-03 19:52:39 +03:00

Owner

Originally created by @trufanblch on GitHub (Mar 31, 2023).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1590

Description

Right now to unpin a domain, a user should click "Delete" which is counterintuitive, and "Delete" has different functionality around the Proxyman (clear/ delete data)

https://user-images.githubusercontent.com/47119760/229146879-68b6bcbc-2b73-4d44-a9d3-7edb020bb7b1.mov

For Pinned items:

a user will see Unpin action on the top of the list (now Pin on the top which is inactive)

Delete action will clear all data for the item

Why this feature/change is important?

Overall UX will be the same around the Proxyman

Originally created by @trufanblch on GitHub (Mar 31, 2023). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1590 ## Description Right now to unpin a domain, a user should click "Delete" which is counterintuitive, and "Delete" has different functionality around the Proxyman (clear/ delete data) https://user-images.githubusercontent.com/47119760/229146879-68b6bcbc-2b73-4d44-a9d3-7edb020bb7b1.mov  For Pinned items: a user will see Unpin action on the top of the list (now Pin on the top which is inactive) Delete action will clear all data for the item ## Why this feature/change is important? Overall UX will be the same around the Proxyman

kerem added the

enhancement

label

2026-03-03 19:52:39 +03:00

kerem commented

2026-03-03 19:52:40 +03:00

Author

Owner

@NghiaTranUIT commented on GitHub (Apr 7, 2023):

Sorry, we don't think that we should change the behavior of the "Delete":

"Delete" (When you right-click on the domain node), mean it will delete this node. It doesn't make sense if the "delete" mean: Keeping the Domain node, but clear all traffic of its domain.
Regarding the "Unpin", it's reasonable, but I still prefer using the "Delete" since it's consistent with other domain nodes.

@NghiaTranUIT commented on GitHub (Apr 7, 2023): Sorry, we don't think that we should change the behavior of the "Delete": - "Delete" (When you right-click on the domain node), mean it will delete this node. It doesn't make sense if the "delete" mean: Keeping the Domain node, but clear all traffic of its domain. - Regarding the "Unpin", it's reasonable, but I still prefer using the "Delete" since it's consistent with other domain nodes.