[GH-ISSUE #1538] Proxyman crashes instantly after loading diff view for big responses #1529

Open
opened 2026-03-03 19:52:14 +03:00 by kerem · 2 comments
Owner

Originally created by @novitae on GitHub (Feb 12, 2023).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1538

Originally assigned to: @NghiaTranUIT on GitHub.

Description

Proxyman crashes when opening diff view on two requests (their responses are both 2.45mb)

Steps to Reproduce

The requests contains sensitive data, where can I send it to you ?

  1. Choose the first request in the file, cmd + y
  2. Choose the second request in the file, cmd + y

Current Behavior

Proxyman instantly crashes after loading the second request

https://user-images.githubusercontent.com/85891169/218305055-68f30ea1-d36d-4005-9229-6b71c5f06993.mov

Expected Behavior

Proxyman should be able to stay in the request diff view, and compare both

Environment

  • App version: Proxyman 4.21
  • macOS version: macOS Ventura 13.2
Originally created by @novitae on GitHub (Feb 12, 2023). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1538 Originally assigned to: @NghiaTranUIT on GitHub. ## Description Proxyman crashes when opening diff view on two requests (their responses are both 2.45mb) ## Steps to Reproduce The requests contains sensitive data, where can I send it to you ? 1. Choose the first request in the file, `cmd + y` 2. Choose the second request in the file, `cmd + y` ## Current Behavior Proxyman instantly crashes after loading the second request https://user-images.githubusercontent.com/85891169/218305055-68f30ea1-d36d-4005-9229-6b71c5f06993.mov ## Expected Behavior Proxyman should be able to stay in the request diff view, and compare both ## Environment - App version: Proxyman 4.21 - macOS version: macOS Ventura 13.2
Author
Owner

@NghiaTranUIT commented on GitHub (Feb 13, 2023):

The GoogleDiff library doesn't feel powerful enough to perform the diff on a 2.5 Mb text body. As a result, it crashed.

I'd propose the following:

  1. If the body is huge (>= 1Mb for example), Proxyman might not perform the diff. Instead, it shows the user to use a different app for diffing, e.g FileMerge from Xcode => Avoid crash
  2. Trimming the body if it's bigger than 1 MB.
<!-- gh-comment-id:1427521665 --> @NghiaTranUIT commented on GitHub (Feb 13, 2023): The GoogleDiff library doesn't feel powerful enough to perform the diff on a 2.5 Mb text body. As a result, it crashed. I'd propose the following: 1. If the body is huge (>= 1Mb for example), Proxyman might not perform the diff. Instead, it shows the user to use a different app for diffing, e.g FileMerge from Xcode => Avoid crash 2. Trimming the body if it's bigger than 1 MB.
Author
Owner

@NghiaTranUIT commented on GitHub (Feb 18, 2023):

@novitae you can try this Beta build: https://download.proxyman.io/beta/Proxyman_4.2.1_New_Diff_v2.dmg

I completely redesign the diff view, it can handle a large JSON file 👍

CleanShot 2023-02-18 at 21 15 08@2x

<!-- gh-comment-id:1435691557 --> @NghiaTranUIT commented on GitHub (Feb 18, 2023): @novitae you can try this Beta build: https://download.proxyman.io/beta/Proxyman_4.2.1_New_Diff_v2.dmg I completely redesign the diff view, it can handle a large JSON file 👍 ![CleanShot 2023-02-18 at 21 15 08@2x](https://user-images.githubusercontent.com/5878421/219871859-6f801891-11e7-4900-af65-16c06a6ff6d7.jpg)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#1529
No description provided.