mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-25 16:15:55 +03:00
[GH-ISSUE #1479] [Bug Report] Protobuf boolean field appears as number in protobuf parsed view #1472
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#1472
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jjmean2 on GitHub (Dec 29, 2022).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1479
Originally assigned to: @NghiaTranUIT on GitHub.
Description
I'm not sure, if it's only for me or not, but in my case, every boolean field of protobuf message appears as number.
So if the value is
true, it shows as1(in JSON form of protobuf parsed value), and if the value isfalse, it is not shown entirely (because it is default value which doesn't include an actual value in packet?)Steps to Reproduce
Current Behavior
Boolean field value appears as number. (1 or nothing)
Expected Behavior
Boolean field value appears as boolean. (true or nothing)
Environment
@NghiaTranUIT commented on GitHub (Dec 29, 2022):
Just wondering: What is the field type (described in protoc/desc file)? Is it Int or Boolean?
@jjmean2 commented on GitHub (Dec 29, 2022):
@NghiaTranUIT
I'm not familiar with proto.desc file format, so I'm not sure if I check correctly. But when I check, I find it is 'bool'. (the value of field.type is 8)
I refer to code of following link.
to read desc file.
https://gist.github.com/justinfx/c2b1458ea2ddab8faf635cacd140ad2d
to find which type has value 8.
https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.descriptor#FieldDescriptor
@siddarthkalra commented on GitHub (Nov 17, 2024):
@NghiaTranUIT any word on this bug fix or a possible workaround? I am seeing the same issue on
Proxyman Version 5.10.0 (51000) | macOS: Version 14.5 (Build 23F79)when inspecting protobuf responses. In particular, this is quite limiting when trying to use the map local tool as all bools are being converted to integers.For me bools are shown as:
when they should be shown as:
@NghiaTranUIT commented on GitHub (Nov 18, 2024):
not yet, but I will include it in the next 2 release 👍
@jjmean2 commented on GitHub (Nov 19, 2024):
Exciting news! Thanks for your concern