mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-25 16:15:55 +03:00
[GH-ISSUE #1428] Is the port number really more readable with a , ? #1421
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#1421
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ekscrypto on GitHub (Nov 7, 2022).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1428
Originally assigned to: @NghiaTranUIT on GitHub.
Description
When hovering the "Proxy overriden" pill on the bottom right it indicates the IP address and the port number. However that port number now has a thousand separators which in this case seems to me more confusing then helping, since you shouldn't be entering that , on the iOS/Android proxy settings.
@NghiaTranUIT commented on GitHub (Nov 7, 2022):
Thousand separator? Can you share with me the screenshot 🤔
@delboy1978uk commented on GitHub (Nov 7, 2022):
@NghiaTranUIT
@NghiaTranUIT commented on GitHub (Nov 7, 2022):
Ah, thanks for the screenshot.it's a UI localized bug. Let me fix it 👋
@NghiaTranUIT commented on GitHub (Nov 8, 2022):
It's fixed @delboy1978uk @ekscrypto https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_3.13.0_Fix_Port_string_format.dmg
This bug is accidentally introduced when Proxyman supports Localization.
String.localizedStringWithFormat()did use a thousand separators on the number. Fix it by converting to a string, not a number 👍@abardallis commented on GitHub (Nov 17, 2022):
FWIW, same thing in the macOS menu bar:
@NghiaTranUIT commented on GitHub (Nov 18, 2022):
Sorry for the inconvenience. I incorrectly used
String.localizedStringWithFormat()again.Here is the Fix: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_3.13.0_Fix_ip_port_localization_again.dmg
Screenshots
@delboy1978uk commented on GitHub (Nov 18, 2022):
You are awesome! Thank you! I reaaalllly like Proxyman, you have made some incredible software! Have a great day!
@abardallis commented on GitHub (Nov 18, 2022):
No inconvenience at all @NghiaTranUIT – Thank you!
Installed the build you just linked and it looks to be fixed.
Also +1 to you being awesome, making incredible software, and me really liking Proxyman 👍