[GH-ISSUE #1383] Remove Zip framework #1377

Closed
opened 2026-03-03 19:50:58 +03:00 by kerem · 1 comment
Owner

Originally created by @NghiaTranUIT on GitHub (Oct 7, 2022).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1383

Description

Currently, ProxymanCore is using ZipFoundation framework and Proxyman for iOS uses Zip. They are basically the same. We should remove the Zip.

Acceptance Criteria

  • Remove Zip framework from NSProxy-iOS target
  • Refactor the code where the Zip is used, by using the new func from ZipFoundation.
Originally created by @NghiaTranUIT on GitHub (Oct 7, 2022). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1383 ## Description Currently, ProxymanCore is using ZipFoundation framework and Proxyman for iOS uses Zip. They are basically the same. We should remove the Zip. ## Acceptance Criteria - Remove Zip framework from NSProxy-iOS target - Refactor the code where the Zip is used, by using the new func from ZipFoundation.
kerem 2026-03-03 19:50:58 +03:00
Author
Owner

@NghiaTranUIT commented on GitHub (Oct 14, 2022):

Turn out we have to use this ZIP library instead of the ZipFoundation library, because the ZIP library maintains the root folder, which is important.

Ref: github.com/NghiaTranUIT/NSProxy@68a043e2e5/NSProxy/NSProxy-iOS/NSProxy-iOS/Source/Services/App/ExportService.swift (L61)

<!-- gh-comment-id:1278449415 --> @NghiaTranUIT commented on GitHub (Oct 14, 2022): Turn out we have to use this ZIP library instead of the ZipFoundation library, because the ZIP library maintains the root folder, which is important. Ref: https://github.com/NghiaTranUIT/NSProxy/blob/68a043e2e51a789e3cc14361c13735e9c2232c3e/NSProxy/NSProxy-iOS/NSProxy-iOS/Source/Services/App/ExportService.swift#L61
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#1377
No description provided.