[GH-ISSUE #140] Improve logic for overriding Proxy from all NetworkInterfaces #136

Closed
opened 2026-03-03 19:15:38 +03:00 by kerem · 2 comments
Owner

Originally created by @NghiaTranUIT on GitHub (May 11, 2019).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/140

Originally assigned to: @NghiaTranUIT on GitHub.

🐶 Brief

Our current implementation is unable to get the correct name of iPhone device when sharing internet via USB. Consequently, Proxyman couldn't override it properly.

We should come up better solution to get correct name, then passing to networksetup cli.

👑 Criteria

  • Remove old implementation
  • Use SystemConfiguration framework to get NetworkInterface name
  • Only return Enable one
  • Override Proxy config in background
Originally created by @NghiaTranUIT on GitHub (May 11, 2019). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/140 Originally assigned to: @NghiaTranUIT on GitHub. ## 🐶 Brief Our current implementation is unable to get the correct name of iPhone device when sharing internet via USB. Consequently, Proxyman couldn't override it properly. We should come up better solution to get correct name, then passing to `networksetup` cli. ## 👑 Criteria - [x] Remove old implementation - [x] Use [SystemConfiguration](https://developer.apple.com/documentation/systemconfiguration?language=objc) framework to get NetworkInterface name - [x] Only return Enable one - [x] Override Proxy config in background
kerem 2026-03-03 19:15:38 +03:00
Author
Owner

@NghiaTranUIT commented on GitHub (May 11, 2019):

All done 💯

🤯 Changelogs

  • New solution to get all NetworkDevices Name from SystemConfiguration framework
  • Run on background thread to boost the launch time
<!-- gh-comment-id:491481454 --> @NghiaTranUIT commented on GitHub (May 11, 2019): All done 💯 ## 🤯 Changelogs - [x] New solution to get all NetworkDevices Name from SystemConfiguration framework - [x] Run on background thread to boost the launch time
Author
Owner

@NghiaTranUIT commented on GitHub (May 11, 2019):

Fixed #133

<!-- gh-comment-id:491481473 --> @NghiaTranUIT commented on GitHub (May 11, 2019): Fixed #133
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#136
No description provided.