mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-27 00:55:57 +03:00
[GH-ISSUE #1263] Scripting Tool Folders feedback #1257
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#1257
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @crankygeek on GitHub (Jun 23, 2022).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1263
Originally assigned to: @NghiaTranUIT on GitHub.
Some various feedback regarding the Scripting folders implementation (I've only looked at Scripting, not the other areas where this is changed). Let me know if anything isn't clear, or if you would like anything broken out into a separate issue.
My initial reaction to Script Editor being a separate window is that it feels like I have too many windows to manage. That said, the choice makes sense, and being able to see multiple scripts at the same time (e.g. separating tabs out into separate windows) has obvious benefits, so I think it's an overall improvement. I wouldn't complain about an option to keep it all in a single window, but I'm not sure it would be worth the time to implement as an option.
Clicking "Save & Activate" on a script doesn't update the checkbox for that script in the Scripting window until the Script Editor window is closed.
I wonder if the "Save & Activate" button on scripts should be changed to just "Save"? Now that scripts won't run unless both the folder and individual script are enabled, and currently, the activation only applies to the script, not the folder. This makes sense, since enabling the folder would turn on all enabled scripts in the folder, which may not be intended by the user. This would also affect the "Saved and Active" indicator above the script editor. Maybe it should only show green if both folder and selected script are active?
Related, I think the individual scripts within a folder should use the disabled-and-checked state (like when the Scripting Tool is disabled, checked checkboxes are grey) if the folder isn't checked.
The Script Editor should remember my editor/console sizes when opening new scripts.
I would like to be able to edit scripts even if the Scripting Tool is disabled. (This isn't a change with the new Scripting UI, but I can't recall if I've mentioned it before.)
I continue to be delighted with how Proxyman keeps improving. Great job @NghiaTranUIT!
@NghiaTranUIT commented on GitHub (Jun 24, 2022):
Thanks for your valuable feedback @crankygeek. I love these insight to make Proxyman even better 🙌
Yes, it's a 🐞
It makes sense. I'm thinking to add a small note to tell the user that the script is disabled by the parent folder too. Or some UI to make it clear.
I added this feature. If the parent folder is disabled, it also greys out the children by disabling them. However, the user could not interact with it, so I revert the change.
Yes, it should be.
@crankygeek commented on GitHub (Jul 18, 2022):
@NghiaTranUIT I like the folders UX update! Just thought of something as I was playing with it that I didn't think of with my initial report. When folders are collapsed, there's no indication if there are active rules within that folder. It would be nice to see and indicator on the folder for this. There's a good pattern to follow from System Preferences > Keyboard > Shortcuts where the top level item has a "dashed" checkbox to indicate this. I've attached a screenshot that shows this.
Also, I noticed that the script editor still isn't preserving panel sizes. Would it help to open a separate issue to track that?
@NghiaTranUIT commented on GitHub (Jul 19, 2022):
Ah, I love the detailed UX of macOS. The
Dashedcheckbox means that there are active rules inside the folder. Love it ❤️I gonna support it 👍
No need, the reason why it doesn't work is that I haven't resolved your ticket yet 😄
I will put it to Proxyman 3.8.0 (next release) 🙌