[GH-ISSUE #1241 ] Duplicated calls with 0 bytes #1237

Author

Owner

@ekurdesov commented on GitHub (May 19, 2022):

the difference between them could vary in like 10-20ms but the only 1 call will have a response with the data.

@ekurdesov commented on GitHub (May 19, 2022): the difference between them could vary in like 10-20ms but the only 1 call will have a response with the data.

kerem commented

Author

Owner

@Groovee60 commented on GitHub (May 19, 2022):

We also verified that our client code is only making one API call corresponding to these unexpected duplicate traffic listings.

Additionally, it now seems that we can only reproduce the failure immediately after clearing Proxyman's traffic window via the garbage can icon at the top of the screen.

@Groovee60 commented on GitHub (May 19, 2022): We also verified that our client code is only making one API call corresponding to these unexpected duplicate traffic listings. Additionally, it now seems that we can only reproduce the failure immediately after clearing Proxyman's traffic window via the garbage can icon at the top of the screen.

kerem commented

Author

Owner

@NghiaTranUIT commented on GitHub (May 19, 2022):

Thanks @ekurdesov and @Groovee60 for the report.

Just wondering:

Does it happen with the iOS simulator/device? (it seems that you're an Android team, if you don't mind, please ask a help from the iOS Team).
How about the Android Emulator?

Meanwhile, I will try to reproduce it in my end 👍

@NghiaTranUIT commented on GitHub (May 19, 2022): Thanks @ekurdesov and @Groovee60 for the report. Just wondering: 1. Does it happen with the iOS simulator/device? (it seems that you're an Android team, if you don't mind, please ask a help from the iOS Team). 2. How about the Android Emulator? Meanwhile, I will try to reproduce it in my end 👍

kerem commented

Author

Owner

@Groovee60 commented on GitHub (May 20, 2022):

Hello, @NghiaTranUIT,

I did reach out to an iOS colleague and he confirmed that he had seen unexpected 0 byte responses. But we have yet to regress the specific steps we were able to nail down. We'll see if we can get further corroboration for you.

When I first saw the multiple API calls, I determined that in some cases, it was a client failure - i.e., I was not inhibiting the user from inadvertently requesting the refresh mechanism twice. When I fixed that, the problem seemed to be resolved, but I soon discovered that the multiple calls could still occur, and later determined that it seemed to require the clearing of the traffic window. None of this makes sense to me, but maybe it will be of assistance to you in reproducing it.

And yes, I was working on a physical device and my colleague was working with an emulator.

Thanks!

@Groovee60 commented on GitHub (May 20, 2022): Hello, @NghiaTranUIT, I did reach out to an iOS colleague and he confirmed that he had seen unexpected 0 byte responses. But we have yet to regress the specific steps we were able to nail down. We'll see if we can get further corroboration for you. When I first saw the multiple API calls, I determined that in some cases, it *was* a client failure - i.e., I was not inhibiting the user from inadvertently requesting the refresh mechanism twice. When I fixed that, the problem seemed to be resolved, but I soon discovered that the multiple calls could still occur, and later determined that it seemed to require the clearing of the traffic window. None of this makes sense to me, but maybe it will be of assistance to you in reproducing it. And yes, I was working on a physical device and my colleague was working with an emulator. Thanks!

kerem commented

Author

Owner

@NghiaTranUIT commented on GitHub (May 22, 2022):

Thanks for the input. I will investigate this issue this week 👍

@NghiaTranUIT commented on GitHub (May 22, 2022): Thanks for the input. I will investigate this issue this week 👍

kerem commented

Author

Owner

@NghiaTranUIT commented on GitHub (May 23, 2022):

@Groovee60 what Networking library you're using on Android? Is it okhttp or retrofit or fast? 🤔

@NghiaTranUIT commented on GitHub (May 23, 2022): @Groovee60 what Networking library you're using on Android? Is it okhttp or retrofit or fast? 🤔

kerem commented

Author

Owner

@Groovee60 commented on GitHub (May 23, 2022):

Retrofit 2.9.0

@Groovee60 commented on GitHub (May 23, 2022): Retrofit 2.9.0

kerem commented

Author

Owner

@NghiaTranUIT commented on GitHub (May 30, 2022):

@Groovee60 @ekurdesov if you don't mind, please try this Beta build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_3.5.0_Fix_Duplicate_issue.dmg

Basically, when the connection is closed, Proxyman might incorrectly generate duplicated requests. Thus, it displays multiple requests.

Let me know if it fixes for you 👍

@NghiaTranUIT commented on GitHub (May 30, 2022): @Groovee60 @ekurdesov if you don't mind, please try this Beta build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_3.5.0_Fix_Duplicate_issue.dmg Basically, when the connection is closed, Proxyman might incorrectly generate duplicated requests. Thus, it displays multiple requests. Let me know if it fixes for you 👍

kerem commented

Author

Owner

@Groovee60 commented on GitHub (May 31, 2022):

Hello - I'm sorry to report that I am still seeing the same failure - three entries for an API endpoint after invoking it only once.
.

@Groovee60 commented on GitHub (May 31, 2022): Hello - I'm sorry to report that I am still seeing the same failure - three entries for an API endpoint after invoking it only once. .

kerem commented

Author

Owner

@Groovee60 commented on GitHub (May 31, 2022):

@Groovee60 commented on GitHub (May 31, 2022): ![Screen Shot 2022-05-31 at 10 14 11 AM](https://user-images.githubusercontent.com/7211332/171234238-98daab9d-74bd-497d-aaf9-f46aa667a979.png)

kerem commented

Author

Owner

@NghiaTranUIT commented on GitHub (Jun 1, 2022):

@Groovee60 It seems they are 3 separate requests, doesn't it? You can see they both have the Response Size, not zero bytes.

Just a side question: Do you have an app on PlayStore that I can install to my Emulator for testing?

@NghiaTranUIT commented on GitHub (Jun 1, 2022): @Groovee60 It seems they are 3 separate requests, doesn't it? You can see they both have the Response Size, not zero bytes. Just a side question: Do you have an app on PlayStore that I can install to my Emulator for testing?

kerem commented

Author

Owner

@Groovee60 commented on GitHub (Jun 1, 2022):

I'm afraid we don't have an app on the PlayStore, it is an internal app. My logging shows that the API call is only being made once. At first I assumed it was some unexpected/misunderstood behavior of Retrofit, but I gave up on that theory when 1) it didn't happen with Charles as the web proxy and 2) it only happened after clearing the Proxyman window.

@Groovee60 commented on GitHub (Jun 1, 2022): I'm afraid we don't have an app on the PlayStore, it is an internal app. My logging shows that the API call is only being made once. At first I assumed it was some unexpected/misunderstood behavior of Retrofit, but I gave up on that theory when 1) it didn't happen with Charles as the web proxy and 2) it only happened after clearing the Proxyman window.

kerem commented

Author

Owner

@NghiaTranUIT commented on GitHub (Jun 1, 2022):

Good news @Groovee60 @ekurdesov 🙌, I'm able to reproduce your issue, and here is the fix: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_3.5.1_Fix_duplicate_request_after_clearing_the_session.dmg

Basically, after we click on the Clear Session button, Proxyman will close all Swift NIO Channels. However, it's an async process. Thus, some requests might be added to the pool.

The fix makes sure that it properly closes the channel.

Not sure why it only happens on Android apps, and it works fine for iOS apps.

@NghiaTranUIT commented on GitHub (Jun 1, 2022): Good news @Groovee60 @ekurdesov 🙌, I'm able to reproduce your issue, and here is the fix: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_3.5.1_Fix_duplicate_request_after_clearing_the_session.dmg Basically, after we click on the Clear Session button, Proxyman will close all Swift NIO Channels. However, it's an async process. Thus, some requests might be added to the pool. The fix makes sure that it properly closes the channel. Not sure why it only happens on Android apps, and it works fine for iOS apps.

kerem commented

Author

Owner

@Groovee60 commented on GitHub (Jun 1, 2022):

Looks like you nailed it - thanks!!!

@Groovee60 commented on GitHub (Jun 1, 2022): Looks like you nailed it - thanks!!!

kerem commented

Author

Owner

@NghiaTranUIT commented on GitHub (Jun 2, 2022):

Thanks. I have 1 customer that confirmed this issue is fixed on their side too. I'm going to release a hotfit today 👍

@NghiaTranUIT commented on GitHub (Jun 2, 2022): Thanks. I have 1 customer that confirmed this issue is fixed on their side too. I'm going to release a hotfit today 👍

kerem commented

Author

Owner

@NghiaTranUIT commented on GitHub (Jun 2, 2022):

@Groovee60 I've released this fix on Proxyman 3.5.2, please update it 👍

Thanks guys for helping me to solve this case 😄

@NghiaTranUIT commented on GitHub (Jun 2, 2022): @Groovee60 I've released this fix on Proxyman 3.5.2, please update it 👍 Thanks guys for helping me to solve this case 😄

kerem commented

Author

Owner

@adamdahan commented on GitHub (Jan 21, 2023):

This is still a problem with iOS

@adamdahan commented on GitHub (Jan 21, 2023): This is still a problem with iOS

kerem commented

Author

Owner

@adamdahan commented on GitHub (Jan 21, 2023):

I see 4 requests for each 1 request in my iOS app

@adamdahan commented on GitHub (Jan 21, 2023): I see 4 requests for each 1 request in my iOS app

kerem commented

Author

Owner

@NghiaTranUIT commented on GitHub (Jan 22, 2023):

Hi @adamdahan you means the Proxyman for iOS app? If it's, what version you're using 🤔

@NghiaTranUIT commented on GitHub (Jan 22, 2023): Hi @adamdahan you means the Proxyman for iOS app? If it's, what version you're using 🤔

kerem commented

Author

Owner

@adamdahan commented on GitHub (Jan 22, 2023):

@NghiaTranUIT this is in the proxyman app. I can tail my server logs and see only a single request but in proxyman app for mac version 4.0.0 you see 4 x the amount of requests for every single endpoint. It's actually what made me stop using the app entirely. It's a lovely product but seems there are some core issues that need some TLC.

@adamdahan commented on GitHub (Jan 22, 2023): @NghiaTranUIT this is in the proxyman app. I can tail my server logs and see only a single request but in proxyman app for mac version 4.0.0 you see 4 x the amount of requests for every single endpoint. It's actually what made me stop using the app entirely. It's a lovely product but seems there are some core issues that need some TLC.

kerem commented

Author

Owner

@adamdahan commented on GitHub (Jan 22, 2023):

The Traffic.Package has different UUID for same requests as well.

@adamdahan commented on GitHub (Jan 22, 2023): The Traffic.Package has different UUID for same requests as well.

kerem commented

Author

Owner

@NghiaTranUIT commented on GitHub (Jan 23, 2023):

@adamdahan not sure what the "Traffic.Package" is?

Can you share with me the name of your iOS app on AppStore? I'd like to download and investigate the bug.

@NghiaTranUIT commented on GitHub (Jan 23, 2023): @adamdahan not sure what the "Traffic.Package" is? Can you share with me the name of your iOS app on AppStore? I'd like to download and investigate the bug.

kerem commented

Author

Owner

@adamdahan commented on GitHub (Jan 23, 2023):

🤔 TrafficPackage is literally the class in Atlantis that represents an intercepted http request. https://github.com/ProxymanApp/atlantis/blob/main/Sources/Packages.swift

@adamdahan commented on GitHub (Jan 23, 2023): 🤔 TrafficPackage is literally the class in Atlantis that represents an intercepted http request. `https://github.com/ProxymanApp/atlantis/blob/main/Sources/Packages.swift`

kerem commented

Author

Owner

@adamdahan commented on GitHub (Jan 23, 2023):

And you can use any app, the proxyman app shows multiple requests for any http request. My app isn't special.

@adamdahan commented on GitHub (Jan 23, 2023): And you can use any app, the proxyman app shows multiple requests for any http request. My app isn't special.

kerem commented

Author

Owner

@NghiaTranUIT commented on GitHub (Jan 23, 2023):

Thanks. I'd like to verify @adamdahan

You're using the Atlantis framework on your iOS app. Make sure to use the latest Atlantis version 1.20.0
Proxyman for macOS 4.0.0
Your iOS app is running on iOS 16

and you see multiple requests for a single request.

Is it correct? Sorry due to lack of information.

@NghiaTranUIT commented on GitHub (Jan 23, 2023): Thanks. I'd like to verify @adamdahan - You're using the Atlantis framework on your iOS app. Make sure to use the latest Atlantis version 1.20.0 - Proxyman for macOS 4.0.0 - Your iOS app is running on iOS 16 and you see multiple requests for a single request. Is it correct? Sorry due to lack of information.

kerem commented

Author

Owner

@adamdahan commented on GitHub (Jan 23, 2023):

iOS 16,
pod atlantis-proxyman (no version specified)
Proxyman for macOS 4.0.0

And I see multiple requests for every request, whether it be from my app or third party sdk like snapchat / firebase etc...

@adamdahan commented on GitHub (Jan 23, 2023): - iOS 16, - pod atlantis-proxyman (no version specified) - Proxyman for macOS 4.0.0 And I see multiple requests for every request, whether it be from my app or third party sdk like snapchat / firebase etc...

kerem commented

Author

Owner

@adamdahan commented on GitHub (Jan 23, 2023):

Sometimes filter by 2xx will clean the requests so it only shows 1. But this is only once in a while. Usually 4x per request.

@adamdahan commented on GitHub (Jan 23, 2023): Sometimes filter by 2xx will clean the requests so it only shows 1. But this is only once in a while. Usually 4x per request.

kerem commented

Author

Owner

@NghiaTranUIT commented on GitHub (Jan 23, 2023):

@adamdahan Sorry but I could not find a reliable way to reproduce your issue. Here is what I've tried:

Use Alamofire example app for iOS 16 iPhone
Add Atlantis 1.2.0.0 via CocoaPod
Add FirebaseCore and FirebaseAnalytic (to mimic your setup)
Use Proxyman for macOS v4.0.0

Result

Could not reproduce the duplicated issue
1 Alamofire Request -> 1 request on the app

If you don't mind @adamdahan , please open the Podfile.lock and share with me the Atlantis version? If it's not the latest version, please update it. I remember that this duplicated was fixed in the latest Atlantis build.

@NghiaTranUIT commented on GitHub (Jan 23, 2023): @adamdahan Sorry but I could not find a reliable way to reproduce your issue. Here is what I've tried: 1. Use Alamofire example app for iOS 16 iPhone 2. Add Atlantis 1.2.0.0 via CocoaPod 3. Add FirebaseCore and FirebaseAnalytic (to mimic your setup) 4. Use Proxyman for macOS v4.0.0 **Result** - Could not reproduce the duplicated issue - 1 Alamofire Request -> 1 request on the app <img width="1668" alt="Screenshot 2023-01-23 at 19 55 41" src="https://user-images.githubusercontent.com/5878421/214059783-cd1f8997-0aae-46fe-a900-aecad7d594b1.png"> ------------- If you don't mind @adamdahan , please open the Podfile.lock and share with me the Atlantis version? If it's not the latest version, please update it. I remember that this duplicated was fixed in the latest Atlantis build.

kerem commented

Author

Owner

@adamdahan commented on GitHub (Jan 23, 2023):

Oh you know what - this is using an older version of atlantis, Podfile.lock:
- atlantis-proxyman (1.18.2)

@adamdahan commented on GitHub (Jan 23, 2023): Oh you know what - this is using an older version of atlantis, Podfile.lock: ` - atlantis-proxyman (1.18.2)`

kerem commented

Author

Owner

@adamdahan commented on GitHub (Jan 23, 2023):

Let me upgrade to the latest and test again - I will report back - if I find issue I will upload a video for you to see. Keep you posted.

@adamdahan commented on GitHub (Jan 23, 2023): Let me upgrade to the latest and test again - I will report back - if I find issue I will upload a video for you to see. Keep you posted.

kerem commented