mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-26 08:35:53 +03:00
[GH-ISSUE #1217] Default OS theme is not detected correctly #1212
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#1212
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @vitalytarasov on GitHub (Apr 28, 2022).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1217
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version?
Version 3.4.0 (30400)
macOS Version?
12.2.1
Steps to reproduce
download and open Proxyman for the first time
Proxyman opens in dark mode which does not correspond to the OS mode (I have set mine to light), however Proxyman settings claims to be using the default OS theme (see screenshot)
Expected behavior
upon startup the application should correct detect current theme and start in light mode when OS is set to light
Screenshots (optional)
@NghiaTranUIT commented on GitHub (Apr 28, 2022):
Thanks for letting me know. By default, Proxyman would use the Dark theme.
It's a UI bug, where it points to macOS Theme. It should select Dark Theme 👍
I'm going to fix it now 🙌
@NghiaTranUIT commented on GitHub (Apr 28, 2022):
Sorry, but I'm unable to reproduce your bug.
Here is how it's done:
Tested on macOS 12.3.1
@jrdodds commented on GitHub (Sep 15, 2022):
If you are intentionally setting the Dark theme by default then shouldn't the Proxyman preferences show that 'Dark Theme' is selected?
When 'macOS Theme' is selected I expect the Proxyman UI to match the OS theme and it does not on first launch. Thereafter selecting one of the other themes and then changing to 'macOS Theme' correctly changes Proxyman to match the OS.
It seems that the bug is that the default (of 'Dark Theme') is incorrectly shown as 'macOs Theme' in the Preferences on first launch. Once the theme is toggled, the Preferences UI starts to correctly show the actual selected theme.
Tested on macOS 12.6 and Proxyman 3.9.0.
@NghiaTranUIT commented on GitHub (Sep 17, 2022):
By default, the Dark Theme is selected in Proxyman Preference -> Appearance.
Thanks for the hint. Unfortunately, I'm still unable to reproduce it : /
Let me investigate the bug on the codebase 👍