mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-29 10:05:52 +03:00
[GH-ISSUE #1102] Response body search stops working sometimes #1097
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#1097
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mprice-banno on GitHub (Jan 8, 2022).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1102
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
2.35.3 (23530)
macOS Version? (Ex. mac 10.14)
11.6
Steps to reproduce
Don't have good steps to reproduce this yet, but it happens quite frequently. Sometimes when searching for text in the body of a response, using ⌘F, the search input field at the top of the response body no longer appears. This seems to happen some time after successfully searching for something. At this point ⌘G still works, finding the previous search term. but you cannot change it.
Expected behavior
Typing ⌘F in the response body, or any of request/response tabs, should bring up the search field at the top of the respective tab.
Screenshots (optional)
@NghiaTranUIT commented on GitHub (Jan 8, 2022):
To use ⌘F, you have to click on the View you would like to show the filter bar.
It's how First Responder from Cocoa App since there are many views on the Windows, so maybe hitting the ⌘F doesn't show the filter bar as you expect.
I guess if you encounter this issue, let try to click on the Body View firstly, then ⌘F to show the filter bar.
@crankygeek commented on GitHub (Jan 10, 2022):
@NghiaTranUIT FWIW, I've run into this as well, though I wasn't able to reproduce with the 2.35.4 beta build you posted yesterday.
@NghiaTranUIT commented on GitHub (Jan 11, 2022):
Thanks for letting me know. I will keep an eye on the issue 👍
@sundeepgupta commented on GitHub (May 9, 2022):
I'm running into this issue on Version 3.4.0 (30400). I have to restart the app to make it work again.
@mprice-banno commented on GitHub (May 19, 2022):
I still don't have good repro steps for this, but I'm hitting it daily now and have to keep restarting Proxyman. Seeing it the current Version 3.5.0 (30500) release.
@NghiaTranUIT commented on GitHub (May 19, 2022):
just wondering: Do your traffic have a huge body? I suspect that the filter operator might take longer. Thus, it blocks the next task in the serial queue.
@mprice-banno commented on GitHub (May 20, 2022):
Not particularly large, most responses are in the 1-24KB range with the occasional 100KB. It's not that the search is taking too long and blocking the next one. It's that the search field completely disappears. You can continue to CTRL-G to search the body for whatever the last search was, but you cannot perform a new search.
@NghiaTranUIT commented on GitHub (May 21, 2022):
@mprice-banno just to clarify that it's a CodeMirror Filter (See the screenshot), not a native Filter?
If it's yes, I guess it's a bug from CodeMirror. I will upgrade the code mirror to the latest version 👍
@mprice-banno commented on GitHub (May 21, 2022):
Yes, that's it. I didn't realize that was non-native.
@crankygeek commented on GitHub (Jul 8, 2022):
@NghiaTranUIT I ran into this again yesterday. I'm still not clear on steps to repro though. Version 3.6.2 (30620)
@NghiaTranUIT commented on GitHub (Aug 24, 2022):
Hey @mprice-banno @crankygeek if you don't mind, please check this build: https://github.com/ProxymanApp/Proxyman/issues/1335#issuecomment-1225130689
The bug is finally reproducible and fixed 💯
@mprice-banno commented on GitHub (Aug 25, 2022):
@NghiaTranUIT Will grab the new build and give it a try. Thanks!
@crankygeek commented on GitHub (Aug 25, 2022):
@NghiaTranUIT I've taken it for a spin and haven't been able to reproduce the issue so far. I'll stick with this build until the release to keep checking it.
I did run into something, and I can't recall what the behavior was like before. If you think this is a bug, let me know and I'll open an issue for it.
Imagine you have two responses that contain the same string, i.e.
accountId. If you search for it in the first response and find it, then switch the second response, click into the response body to set focus, and enter ⌘G, it doesn't find the match, even though the string is still displayed in the search field.@NghiaTranUIT commented on GitHub (Aug 26, 2022):
You're right, some don't work well with the latest CodeMirror 5.
Here is a sneak peek of what we're working on. Replacing the CodeMirror with Monaco Editor (powered VS Code). The search bar is better IMO.