mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-25 16:15:55 +03:00
[GH-ISSUE #1027] [BUG] Problem with requests when repeatedly quickly #1022
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#1022
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @CyberMew on GitHub (Oct 13, 2021).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1027
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
2.33.0
macOS Version? (Ex. mac 10.14)
11.6
Steps to reproduce
Repeat call of a request by spamming cmd+return quickly, say 5 times. The ID will not be in correct order and request should go through.
Expected behavior
ID should be sequential, and http status code of those request should not be 999
Screenshots (optional)
This seems like some race condition issue to me, but I am happy to be wrong if this isn't a bug.
@NghiaTranUIT commented on GitHub (Oct 13, 2021):
Confirmed that it's a bug from Proxyman @CyberMew. Thanks for creating a bug 🙌
@VinceFilary commented on GitHub (Feb 26, 2022):
There seems to be some kind of request ID counter race condition.
Multiple requests (not originating from Proxyman) can be assigned the same ID when made quick enough.
Both requests will go through and have separate entries in the log table and respond & complete properly.
(Only seeing the
Error/999status issue when using CMD + Return)This issue also impacts scripting and
sharedStatesince they have the same ID, there is no way to differentiate between these requests/responses.@NghiaTranUIT commented on GitHub (Feb 26, 2022):
Thanks @VinceFilary I'm going to investigate and fix it now 👍
@NghiaTranUIT commented on GitHub (Feb 28, 2022):
@VinceFilary @CyberMew please try this build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_3.1.0_Fix_repeated_requests.dmg
I've fixed the issue where:
@VinceFilary commented on GitHub (Feb 28, 2022):
Just tested out build you provided @NghiaTranUIT .
Issue is resolved when repeatings requests quickly using CMD + Return.
Issue is also resolved when sending multiple requests quickly not originating from Proxyman.
However, when I
Enable Scripting Tooland enable for an endpoint it starts assigning the same ID to separate requests again.Additional debug info:
If I enable
Enable Scripting Tool, and disable the matching rule for the endpoint it doesn't happen.It happens even if I use the default scripting template, so it's not an issue with my custom script.
@NghiaTranUIT commented on GitHub (Feb 28, 2022):
Can you share the screenshot of
the same ID in separated requests? (You can censor your sensitive URL)From what I understand, the Scripting doesn't issue any new request ID, so I'm not sure how it looks like 🤔