[GH-ISSUE #1027] [BUG] Problem with requests when repeatedly quickly #1022

Open
opened 2026-03-03 19:23:50 +03:00 by kerem · 6 comments
Owner

Originally created by @CyberMew on GitHub (Oct 13, 2021).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1027

Originally assigned to: @NghiaTranUIT on GitHub.

Proxyman version? (Ex. Proxyman 1.4.3)

2.33.0

macOS Version? (Ex. mac 10.14)

11.6

Steps to reproduce

Repeat call of a request by spamming cmd+return quickly, say 5 times. The ID will not be in correct order and request should go through.

Expected behavior

ID should be sequential, and http status code of those request should not be 999

Screenshots (optional)

pms

This seems like some race condition issue to me, but I am happy to be wrong if this isn't a bug.

Originally created by @CyberMew on GitHub (Oct 13, 2021). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1027 Originally assigned to: @NghiaTranUIT on GitHub. ### Proxyman version? (Ex. Proxyman 1.4.3) 2.33.0 ### macOS Version? (Ex. mac 10.14) 11.6 ### Steps to reproduce Repeat call of a request by spamming cmd+return quickly, say 5 times. The ID will not be in correct order and request should go through. ### Expected behavior ID should be sequential, and http status code of those request should not be 999 ### Screenshots (optional) <img width="974" alt="pms" src="https://user-images.githubusercontent.com/4715911/137092831-57752268-5341-4947-9298-611af3baf17e.png"> This seems like some race condition issue to me, but I am happy to be wrong if this isn't a bug.
Author
Owner

@NghiaTranUIT commented on GitHub (Oct 13, 2021):

Confirmed that it's a bug from Proxyman @CyberMew. Thanks for creating a bug 🙌

<!-- gh-comment-id:942190708 --> @NghiaTranUIT commented on GitHub (Oct 13, 2021): Confirmed that it's a bug from Proxyman @CyberMew. Thanks for creating a bug 🙌
Author
Owner

@VinceFilary commented on GitHub (Feb 26, 2022):

There seems to be some kind of request ID counter race condition.

Multiple requests (not originating from Proxyman) can be assigned the same ID when made quick enough.
Both requests will go through and have separate entries in the log table and respond & complete properly.
(Only seeing the Error / 999 status issue when using CMD + Return)

This issue also impacts scripting and sharedState since they have the same ID, there is no way to differentiate between these requests/responses.

<!-- gh-comment-id:1051958253 --> @VinceFilary commented on GitHub (Feb 26, 2022): There seems to be some kind of request ID counter race condition. Multiple requests (not originating from Proxyman) can be assigned the same ID when made quick enough. Both requests will go through and have separate entries in the log table and respond & complete properly. (Only seeing the `Error` / `999` status issue when using CMD + Return) This issue also impacts scripting and `sharedState` since they have the same ID, there is no way to differentiate between these requests/responses.
Author
Owner

@NghiaTranUIT commented on GitHub (Feb 26, 2022):

Thanks @VinceFilary I'm going to investigate and fix it now 👍

<!-- gh-comment-id:1052133635 --> @NghiaTranUIT commented on GitHub (Feb 26, 2022): Thanks @VinceFilary I'm going to investigate and fix it now 👍
Author
Owner

@NghiaTranUIT commented on GitHub (Feb 28, 2022):

@VinceFilary @CyberMew please try this build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_3.1.0_Fix_repeated_requests.dmg

I've fixed the issue where:

  • Repeated requests causes duplicated request ID
  • Small race condition issue on the ID number

2022-02-28 09 10 22

<!-- gh-comment-id:1053800793 --> @NghiaTranUIT commented on GitHub (Feb 28, 2022): @VinceFilary @CyberMew please try this build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_3.1.0_Fix_repeated_requests.dmg I've fixed the issue where: - Repeated requests causes duplicated request ID - Small race condition issue on the ID number ![2022-02-28 09 10 22](https://user-images.githubusercontent.com/5878421/155912874-307aac58-8a69-4bbe-bdd9-d111e0e812af.gif)
Author
Owner

@VinceFilary commented on GitHub (Feb 28, 2022):

Just tested out build you provided @NghiaTranUIT .

Issue is resolved when repeatings requests quickly using CMD + Return.
Issue is also resolved when sending multiple requests quickly not originating from Proxyman.

However, when I Enable Scripting Tool and enable for an endpoint it starts assigning the same ID to separate requests again.

Additional debug info:

If I enable Enable Scripting Tool, and disable the matching rule for the endpoint it doesn't happen.
It happens even if I use the default scripting template, so it's not an issue with my custom script.

<!-- gh-comment-id:1054021408 --> @VinceFilary commented on GitHub (Feb 28, 2022): Just tested out build you provided @NghiaTranUIT . Issue is resolved when repeatings requests quickly using CMD + Return. Issue is also resolved when sending multiple requests quickly not originating from Proxyman. However, when I `Enable Scripting Tool` and enable for an endpoint it starts assigning the same ID to separate requests again. Additional debug info: If I enable `Enable Scripting Tool`, and disable the matching rule for the endpoint it doesn't happen. It happens even if I use the default scripting template, so it's not an issue with my custom script.
Author
Owner

@NghiaTranUIT commented on GitHub (Feb 28, 2022):

Can you share the screenshot of the same ID in separated requests? (You can censor your sensitive URL)

From what I understand, the Scripting doesn't issue any new request ID, so I'm not sure how it looks like 🤔

<!-- gh-comment-id:1054024069 --> @NghiaTranUIT commented on GitHub (Feb 28, 2022): Can you share the screenshot of `the same ID in separated requests`? (You can censor your sensitive URL) From what I understand, the Scripting doesn't issue any new request ID, so I'm not sure how it looks like 🤔
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#1022
No description provided.