starred/Proxyman
1
0
Fork 0
mirror of https://github.com/ProxymanApp/Proxyman.git synced 2026-04-27 00:55:57 +03:00
Code Issues 1.2k Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #1011] XML Charset WINDOWS-1251 issue #1005

New issue
Open
opened 2026-03-03 19:23:42 +03:00 by kerem · 11 comments
kerem commented 2026-03-03 19:23:42 +03:00
Owner
Copy link

Originally created by @azhabort on GitHub (Oct 1, 2021).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1011

Originally assigned to: @NghiaTranUIT on GitHub.

Proxyman version? (Ex. Proxyman 1.4.3)

Version 2.33.0 (23300)

macOS Version? (Ex. mac 10.14)

12.0 Beta (21A5522h)

Steps to reproduce

  1. Make a request and get a response with xml data inside. XML should use windows-1251 charset
    <?xml version="1.0" encoding="windows-1251" ?>
  2. Setup custom body preview tabs and select XML option.
  3. Cyrillic xml data shows with wrong encoding

Expected behavior

XML data with cyrillic characters inside should be encoded correctly.

Screenshots (optional)

raw preview tab:
screen_01
xml body preview tab
screen_02

Originally created by @azhabort on GitHub (Oct 1, 2021). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/1011 Originally assigned to: @NghiaTranUIT on GitHub. ### Proxyman version? (Ex. Proxyman 1.4.3) Version 2.33.0 (23300) ### macOS Version? (Ex. mac 10.14) 12.0 Beta (21A5522h) ### Steps to reproduce 1. Make a request and get a response with xml data inside. XML should use windows-1251 charset `<?xml version="1.0" encoding="windows-1251" ?>` 2. Setup custom body preview tabs and select XML option. 3. Cyrillic xml data shows with wrong encoding ### Expected behavior XML data with cyrillic characters inside should be encoded correctly. ### Screenshots (optional) raw preview tab: <img width="613" alt="screen_01" src="https://user-images.githubusercontent.com/6636754/135628250-644de97e-704f-46b1-835e-df335052c60c.png"> xml body preview tab <img width="584" alt="screen_02" src="https://user-images.githubusercontent.com/6636754/135628305-74a01584-2f27-47f1-a8be-b3a7c061cd4d.png">
kerem commented 2026-03-03 19:23:43 +03:00
Author
Owner
Copy link

@NghiaTranUIT commented on GitHub (Oct 1, 2021):

Thanks for the report @azhabort 👍 It's definitely a bug 🐞

I will fix it and send you a beta soon

<!-- gh-comment-id:932232331 --> @NghiaTranUIT commented on GitHub (Oct 1, 2021): Thanks for the report @azhabort 👍 It's definitely a bug 🐞 I will fix it and send you a beta soon
kerem commented 2026-03-03 19:23:43 +03:00
Author
Owner
Copy link

@azhabort commented on GitHub (Oct 1, 2021):

@NghiaTranUIT looks like this issue was introduced in 2.33.0 version and relates to fix in the https://github.com/ProxymanApp/Proxyman/issues/989

<!-- gh-comment-id:932240918 --> @azhabort commented on GitHub (Oct 1, 2021): @NghiaTranUIT looks like this issue was introduced in 2.33.0 version and relates to fix in the https://github.com/ProxymanApp/Proxyman/issues/989
kerem commented 2026-03-03 19:23:43 +03:00
Author
Owner
Copy link

@NghiaTranUIT commented on GitHub (Oct 1, 2021):

If you don't mind, please try this beta build and let me know if it works: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.33.0_Fix_XML_Encoding.dmg

<!-- gh-comment-id:932279927 --> @NghiaTranUIT commented on GitHub (Oct 1, 2021): If you don't mind, please try this beta build and let me know if it works: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.33.0_Fix_XML_Encoding.dmg
kerem commented 2026-03-03 19:23:43 +03:00
Author
Owner
Copy link

@NghiaTranUIT commented on GitHub (Oct 1, 2021):

Technically, I use NSXMLDocument to prettify the XML content. To parsing the encoding, CFStringConvertIANACharSetNameToEncoding is used to convert IANA name to NSString.Encoding that XMLDocument understand.

However, for some reason, it doesn't work in your cases (windows-2151).

If the beta build doesn't work. I might find alternative solution 👍 @azhabort

<!-- gh-comment-id:932282048 --> @NghiaTranUIT commented on GitHub (Oct 1, 2021): Technically, I use [NSXMLDocument](https://developer.apple.com/documentation/foundation/nsxmldocument) to prettify the XML content. To parsing the encoding, `CFStringConvertIANACharSetNameToEncoding` is used to convert IANA name to NSString.Encoding that XMLDocument understand. However, for some reason, it doesn't work in your cases (windows-2151). If the beta build doesn't work. I might find alternative solution 👍 @azhabort
kerem commented 2026-03-03 19:23:43 +03:00
Author
Owner
Copy link

@azhabort commented on GitHub (Oct 1, 2021):

@NghiaTranUIT Thanks! I've checked Proxyman_2.33.0_Fix_XML_Encoding.dmg and can confirm that issue is fixed there!

<!-- gh-comment-id:932309858 --> @azhabort commented on GitHub (Oct 1, 2021): @NghiaTranUIT Thanks! I've checked Proxyman_2.33.0_Fix_XML_Encoding.dmg and can confirm that issue is fixed there!
kerem commented 2026-03-03 19:23:43 +03:00
Author
Owner
Copy link

@NghiaTranUIT commented on GitHub (Oct 2, 2021):

Awesome 😄

<!-- gh-comment-id:932662265 --> @NghiaTranUIT commented on GitHub (Oct 2, 2021): Awesome 😄
kerem commented 2026-03-03 19:23:43 +03:00
Author
Owner
Copy link

@NghiaTranUIT commented on GitHub (Oct 2, 2021):

Hey @azhabort please try this build too: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.33.0_XML_encoding.dmg

I refactor and use a different library than NSXMLDocument to properly parse the XML content with a given encoding.

This build would fix all encoding issue, include #989 👍

<!-- gh-comment-id:932673059 --> @NghiaTranUIT commented on GitHub (Oct 2, 2021): Hey @azhabort please try this build too: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.33.0_XML_encoding.dmg I refactor and use a different library than NSXMLDocument to properly parse the XML content with a given encoding. This build would fix all encoding issue, include #989 👍
kerem commented 2026-03-03 19:23:43 +03:00
Author
Owner
Copy link

@azhabort commented on GitHub (Oct 15, 2021):

@NghiaTranUIT Hi! I've checked latest 2.34 version and issue is fixed there.
But alignment is missing now:
Screenshot 2021-10-15 at 16 20 25

<!-- gh-comment-id:944296763 --> @azhabort commented on GitHub (Oct 15, 2021): @NghiaTranUIT Hi! I've checked latest 2.34 version and issue is fixed there. But alignment is missing now: <img width="693" alt="Screenshot 2021-10-15 at 16 20 25" src="https://user-images.githubusercontent.com/6636754/137493537-6675aacd-a8fa-47bf-8aec-51a676e77ece.png">
kerem commented 2026-03-03 19:23:43 +03:00
Author
Owner
Copy link

@NghiaTranUIT commented on GitHub (Oct 15, 2021):

Sorry for this. Let me check and fix it 😢

<!-- gh-comment-id:944297881 --> @NghiaTranUIT commented on GitHub (Oct 15, 2021): Sorry for this. Let me check and fix it 😢
kerem commented 2026-03-03 19:23:43 +03:00
Author
Owner
Copy link

@NghiaTranUIT commented on GitHub (Oct 15, 2021):

@azhabort please check this build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.34.0_Fix_XML_Prettify.dmg

Sorry for my mistake, there is one param is missing 🙀

I will roll out a hot fix tomorrow 👍

<!-- gh-comment-id:944310158 --> @NghiaTranUIT commented on GitHub (Oct 15, 2021): @azhabort please check this build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_2.34.0_Fix_XML_Prettify.dmg Sorry for my mistake, there is one param is missing 🙀 I will roll out a hot fix tomorrow 👍
kerem commented 2026-03-03 19:23:43 +03:00
Author
Owner
Copy link

@azhabort commented on GitHub (Oct 15, 2021):

@NghiaTranUIT I've checked this version and alignment is finally there!
Screenshot 2021-10-15 at 17 11 26

<!-- gh-comment-id:944335445 --> @azhabort commented on GitHub (Oct 15, 2021): @NghiaTranUIT I've checked this version and alignment is finally there! <img width="488" alt="Screenshot 2021-10-15 at 17 11 26" src="https://user-images.githubusercontent.com/6636754/137501471-720f4288-69b6-4239-93a6-5440df1e6259.png">
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
6.9.0
6.8.0
6.7.0
6.6.0
6.5.0
6.4.0
6.3.0
6.2.0
6.1.0
6.0.2
6.0.0
6.0.1
5.25.0
5.24.0
5.23.0
5.23.1
5.22.0
5.20.0
5.21.0
5.19.0
5.18.0
5.17.0
5.16.0
5.15.0
5.14.0
5.12.2
5.12.1
5.12.0
5.11.0
5.10.0
5.8.0
5.9.0
5.7.0
5.6.1
5.6.0
5.5.0
5.4.0
5.2.0
5.3.0
5.1.1
5.0.0
4.16.0
4.15.0
4.14.0
4.13.0
4.12.0
4.11.0
4.10.0
4.9.1
4.9.0
4.8.2
4.8.1
4.8.0
4.7.1
4.7.0
4.6.1
4.6.0
4.5.0
4.4.0
4.3.1
4.3.0
4.2.1
4.2.0
4.1.0
4.0.0
3.15.0
3.14.0
3.13.0
3.12.0
3.11.0
3.10.0
3.9.0
3.8.0
3.7.0
3.6.2
3.6.1
3.6.0
3.5.2
3.5.1
3.5.0
3.4.0
3.3.0
3.2.0
3.1.0
3.0.0
2.35.4
2.35.3
2.35.2
2.35.1
2.35.0
2.34.1
2.34.0
2.33.0
2.32.1
2.32.0
2.31.0
2.30.0
2.29.0
2.28.0
2.27.0
2.26.0
2.25.0
2.24.0
2.23.0
2.22.0
2.21.1
2.21.0
2.20.0
2.19.0
2.18.0
2.17.0
2.16.1
2.16.0
2.15.2
2.15.1
2.15.0
2.14.2
2.14.1
2.14.0
2.13.0
2.12.0
2.11.1
2.11.0
2.10.0
2.9.1
2.9.0
2.8.0
2.7.0
2.6.0
2.5.3
2.5.2
2.5.1
2.5.0
2.4.2
2.4.1
2.4.0
2.3.0
2.2.0
2.1.1
2.1.0
2.0.1
2.0.0
1.24.0
1.23.0
1.22.0
1.21.0
1.20.0
1.19.0
1.18.1
1.18.0
1.17.1
1.17.0
1.16.0
1.15.0
1.14.1
1.14.0
1.13.1
1.13.0
1.12.0
1.11.0
1.10.0
1.9.3
1.9.2
1.9.1
1.9.0
1.8.0
1.7.2
1.7.1
1.7.0
1.6.2
1.6.1
1.6.0
1.5.1
1.5.0
1.4.7
1.4.6
1.4.5.1
1.4.5
1.4.4.1
1.4.4
1.4.3
1.4.2
1.4.1.1
1.4.1
1.4
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4.3
1.3.4.2
1.3.4.1
1.3.4
1.3.3
1.3.2
1.3.1
1.3
1.2
1.1.2
1.1.1
1.1
1.0.3
1.0.2
1.0
0.8.1
0.8
0.7
0.6
0.5.1
0.5
v0.4.1
Labels
Clear labels   
Discussion

   
Feature request

   
In Progress...

   
Plugins

   
Waiting response

   
Windows

   
Windows

   
bug

   
duplicate

   
enhancement

   
feature

   
good first issue

   
iOS

   
macOS 10.11

   
question

   
wontfix

   
✅ Done
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#1005
No description provided.