[PR #11752] [MERGED] feat: improve storage parsing & add guestname #9724

New issue

Closed

opened 2026-02-26 17:31:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 17:31:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/11752
Author: @carlosmaroot
Created: 2/10/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @MickLesk

Base: main ← Head: fix/backup-detection-and-notes

📝 Commits (1)

458ebfe feat: enhance backup notes with guest name and improve whitespace handling and content line matching in container parsing.

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 tools/pve/update-apps.sh (+3 -3)

📄 Description

✍️ Description

Fixed an issue where backup storages were not detected due to strict whitespace parsing in storage.cfg (handling tabs/spaces correctly). Additionally, updated the backup function to include the container's hostname ({{guestname}}) in the backup notes for easier identification.

Fixes #

✅ Prerequisites (X in brackets)

[X] Self-review completed – Code follows project standards.
[X] Tested thoroughly – Changes work as expected.
[X] No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

[X] 🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.
🆕 New script – A fully functional and tested script or script set.
🌍 Website update – Changes to website-related JSON files or metadata.
🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/11752 **Author:** [@carlosmaroot](https://github.com/carlosmaroot) **Created:** 2/10/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `fix/backup-detection-and-notes` --- ### 📝 Commits (1) - [`458ebfe`](https://github.com/community-scripts/ProxmoxVE/commit/458ebfe2870a9b3835774f797450c21dde3f9daf) feat: enhance backup notes with guest name and improve whitespace handling and content line matching in container parsing. ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `tools/pve/update-apps.sh` (+3 -3) </details> ### 📄 Description ## ✍️ Description Fixed an issue where backup storages were not detected due to strict whitespace parsing in `storage.cfg` (handling tabs/spaces correctly). Additionally, updated the backup function to include the container's hostname (`{{guestname}}`) in the backup notes for easier identification. ## 🔗 Related Issue Fixes # ## ✅ Prerequisites (**X** in brackets) - [**X**] **Self-review completed** – Code follows project standards. - [**X**] **Tested thoroughly** – Changes work as expected. - [**X**] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [**X**] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 17:31:29 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#9724

No description provided.

Rows
Columns