[PR #11549] [CLOSED] Add optional EMQX MQ configuration setting before installation #9569

Closed
opened 2026-02-26 17:30:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/11549
Author: @sim-san
Created: 2/4/2026
Status: Closed

Base: mainHead: fix-emqx


📝 Commits (3)

  • 27cdc11 feat: add setting for emqx mq
  • 4b4cc94 fix: remove duplicated seetings
  • 644ec18 fix: increase disk to 6GB

📊 Changes

2 files changed (+13 additions, -3 deletions)

View changed files

📝 ct/emqx.sh (+12 -2)
📝 frontend/public/json/emqx.json (+1 -1)

📄 Description

✍️ Description

In this PR, I am adding a pre-installation prompt that allows users to enable or disable EMQX MQ functionality before container creation. This addresses a configuration requirement documented in the upstream EMQX issue.

Key Changes

• Updated resource requirements: HDD 4 -> 6 GB
• Added emqx_mq_setting() function to prompt user for EMQX MQ configuration
• Export EMQX_MQ__ENABLE environment variable (true/false) based on user selection

Fixes https://github.com/emqx/emqx/issues/16649
See: https://github.com/emqx/emqx/issues/16649#issuecomment-3848341524

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/11549 **Author:** [@sim-san](https://github.com/sim-san) **Created:** 2/4/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-emqx` --- ### 📝 Commits (3) - [`27cdc11`](https://github.com/community-scripts/ProxmoxVE/commit/27cdc11d852cbaf8b55cc39faa585d36d35482df) feat: add setting for emqx mq - [`4b4cc94`](https://github.com/community-scripts/ProxmoxVE/commit/4b4cc94bd2fbf328db3a60a82eeaeb62ec96e73b) fix: remove duplicated seetings - [`644ec18`](https://github.com/community-scripts/ProxmoxVE/commit/644ec1840b104a084718a8e1a9f5d49bc1ad3c26) fix: increase disk to 6GB ### 📊 Changes **2 files changed** (+13 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `ct/emqx.sh` (+12 -2) 📝 `frontend/public/json/emqx.json` (+1 -1) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description In this PR, I am adding a pre-installation prompt that allows users to enable or disable EMQX MQ functionality before container creation. This addresses a configuration requirement documented in the upstream EMQX issue. Key Changes • Updated resource requirements: HDD 4 -> 6 GB • Added emqx_mq_setting() function to prompt user for EMQX MQ configuration • Export EMQX_MQ__ENABLE environment variable (true/false) based on user selection ## 🔗 Related Issue Fixes https://github.com/emqx/emqx/issues/16649 See: https://github.com/emqx/emqx/issues/16649#issuecomment-3848341524 ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [ ] **Tested thoroughly** – Changes work as expected. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [X] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 17:30:56 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#9569
No description provided.