[PR #11512] [MERGED] [FIX] tools.func: trim spaces in app_lc when checking for gh release #9539

Closed
opened 2026-02-26 17:30:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/11512
Author: @vhsdream
Created: 2/3/2026
Status: Merged
Merged: 2/3/2026
Merged by: @CrazyWolf13

Base: mainHead: fix/release-file-parsing


📝 Commits (1)

  • d53359c [FIX] tools.func: trim spaces in app_lc

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 misc/tools.func (+2 -1)

📄 Description

✍️ Description

  • Don't know if this caused any problems for any deployments but I noticed that fetch_and_deploy_gh_release trims all spaces before writing the . file, so I figured that check_for_gh_release should as well.

Fixes #

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/11512 **Author:** [@vhsdream](https://github.com/vhsdream) **Created:** 2/3/2026 **Status:** ✅ Merged **Merged:** 2/3/2026 **Merged by:** [@CrazyWolf13](https://github.com/CrazyWolf13) **Base:** `main` ← **Head:** `fix/release-file-parsing` --- ### 📝 Commits (1) - [`d53359c`](https://github.com/community-scripts/ProxmoxVE/commit/d53359ccad0e42e5d7d1f5502308f6fee020fb0e) [FIX] tools.func: trim spaces in app_lc ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `misc/tools.func` (+2 -1) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description - Don't know if this caused any problems for any deployments but I noticed that `fetch_and_deploy_gh_release` [trims all spaces](https://github.com/community-scripts/ProxmoxVE/blob/fb368bc2d88279c35e2864f5c32c8b3e8547ca94/misc/tools.func#L2329) before writing the .<app> file, so I figured that `check_for_gh_release` should as well. ## 🔗 Related Issue Fixes # ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 17:30:50 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#9539
No description provided.