[PR #11268] [MERGED] core: update dynamic values in LXC profile on update_motd_ip #9354

Closed
opened 2026-02-26 16:36:00 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/11268
Author: @MickLesk
Created: 1/28/2026
Status: Merged
Merged: 1/28/2026
Merged by: @CrazyWolf13

Base: mainHead: feature/regenerate-motd-on-update


📝 Commits (2)

  • f219618 feat(build.func): update dynamic values in LXC profile on update_motd_ip
  • e79a1b3 add update_motd_ip in routine

📊 Changes

1 file changed (+24 additions, -0 deletions)

View changed files

📝 misc/build.func (+24 -0)

📄 Description

✍️ Description

  • Updates only OS/Hostname/IP lines in /etc/profile.d/00_lxc-details.sh
  • Checks if values changed before updating (avoids unnecessary I/O)
  • Preserves user customizations (app name, GitHub link, custom lines)
  • Only updates if file exists and contains 'community-scripts' marker
  • Fixes outdated OS version display after in-place upgrades (e.g., Bookworm → Trixie)
  • Now reads OS name/version from /etc/os-release at login time

Fixes #11261

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/11268 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 1/28/2026 **Merged by:** [@CrazyWolf13](https://github.com/CrazyWolf13) **Base:** `main` ← **Head:** `feature/regenerate-motd-on-update` --- ### 📝 Commits (2) - [`f219618`](https://github.com/community-scripts/ProxmoxVE/commit/f2196185975791efdae040b659788ee2956864a0) feat(build.func): update dynamic values in LXC profile on update_motd_ip - [`e79a1b3`](https://github.com/community-scripts/ProxmoxVE/commit/e79a1b3b3f8aa7766505bbd71e35a904398abf4c) add update_motd_ip in routine ### 📊 Changes **1 file changed** (+24 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+24 -0) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description - Updates only OS/Hostname/IP lines in /etc/profile.d/00_lxc-details.sh - Checks if values changed before updating (avoids unnecessary I/O) - Preserves user customizations (app name, GitHub link, custom lines) - Only updates if file exists and contains 'community-scripts' marker - Fixes outdated OS version display after in-place upgrades (e.g., Bookworm → Trixie) - Now reads OS name/version from /etc/os-release at login time ## 🔗 Related Issue Fixes #11261 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [x] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 16:36:00 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#9354
No description provided.