[PR #11254] [MERGED] tools.func: fix php "wait_for" hint #9343

Closed
opened 2026-02-26 16:35:58 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/11254
Author: @MickLesk
Created: 1/28/2026
Status: Merged
Merged: 1/28/2026
Merged by: @tremor021

Base: mainHead: fix/php-ubuntu-ppa-wait-error


📝 Commits (2)

  • 8f36204 fix(tools.func): resolve wait_for error in PHP setup for Ubuntu
  • eb2ecce fix(tools.func): resolve wait_for error in PHP keyring installation for Debian

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 misc/tools.func (+4 -2)

📄 Description

✍️ Description

Example: ⠋ Configuring PHP/dev/fd/62: line 254: wait_for: No record of process 16904

The problem is that when dpkg -i or add-apt-repository start internal background processes (with &) and then call wait on them, these processes lose their parent context due to process substitution (source <(curl ...)).

So STD isnt a solution here, we need to redirect directly into logfile

Fixes #

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/11254 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 1/28/2026 **Merged by:** [@tremor021](https://github.com/tremor021) **Base:** `main` ← **Head:** `fix/php-ubuntu-ppa-wait-error` --- ### 📝 Commits (2) - [`8f36204`](https://github.com/community-scripts/ProxmoxVE/commit/8f362041fa8a2296b389535a95351a45a335dc50) fix(tools.func): resolve wait_for error in PHP setup for Ubuntu - [`eb2ecce`](https://github.com/community-scripts/ProxmoxVE/commit/eb2ecce548d48145acaf968f4db46f803dec500e) fix(tools.func): resolve wait_for error in PHP keyring installation for Debian ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `misc/tools.func` (+4 -2) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description Example: ⠋ Configuring PHP/dev/fd/62: line 254: wait_for: No record of process 16904 The problem is that when dpkg -i or add-apt-repository start internal background processes (with &) and then call wait on them, these processes lose their parent context due to process substitution (source <(curl ...)). So STD isnt a solution here, we need to redirect directly into logfile ## 🔗 Related Issue Fixes # ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 16:35:58 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#9343
No description provided.