[PR #10833] [MERGED] PDM: avoid installing useless package #9038

Closed
opened 2026-02-26 16:34:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/10833
Author: @LongQT-sea
Created: 1/15/2026
Status: Merged
Merged: 1/23/2026
Merged by: @CrazyWolf13

Base: mainHead: patch-1


📝 Commits (3)

  • 8681450 chore: avoid installing useless package
  • 2276822 Apply requested changes from PR review
  • bd28a7a Update install/proxmox-datacenter-manager-install.sh

📊 Changes

1 file changed (+9 additions, -1 deletions)

View changed files

📝 install/proxmox-datacenter-manager-install.sh (+9 -1)

📄 Description

✍️ Description

This avoids installing unnecessary packages in the container.

Fixes #

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/10833 **Author:** [@LongQT-sea](https://github.com/LongQT-sea) **Created:** 1/15/2026 **Status:** ✅ Merged **Merged:** 1/23/2026 **Merged by:** [@CrazyWolf13](https://github.com/CrazyWolf13) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (3) - [`8681450`](https://github.com/community-scripts/ProxmoxVE/commit/86814506cc350f47601039efa3f0d585da7da5dc) chore: avoid installing useless package - [`2276822`](https://github.com/community-scripts/ProxmoxVE/commit/227682281012d89edb0fe7a56b686ba7cd763fb9) Apply requested changes from PR review - [`bd28a7a`](https://github.com/community-scripts/ProxmoxVE/commit/bd28a7a68572b15b06ae781e952bea991075a382) Update install/proxmox-datacenter-manager-install.sh ### 📊 Changes **1 file changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `install/proxmox-datacenter-manager-install.sh` (+9 -1) </details> ### 📄 Description ## ✍️ Description This avoids installing unnecessary packages in the container. ## 🔗 Related Issue Fixes # ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [X] **Tested thoroughly** – Changes work as expected. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [X] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 16:34:56 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#9038
No description provided.