[PR #9789] [MERGED] Add optional TLS setup to Valkey installer #8275

Closed
opened 2026-02-26 16:32:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/9789
Author: @pshankinclarke
Created: 12/9/2025
Status: Merged
Merged: 12/13/2025
Merged by: @tremor021

Base: mainHead: valkey-tls


📝 Commits (4)

📊 Changes

1 file changed (+37 additions, -1 deletions)

View changed files

📝 install/valkey-install.sh (+37 -1)

📄 Description

✍️ Description

Automatic configuration of TLS gives users an easy option to encrypt Valkey traffic and protect the generated password without need to manually edit valkey.conf or reason about TLS details for each LXC instance.

I tested 3 cases (TLS disabled, TLS+TCP, TLS-only), checking valkey.conf, the listening ports, and valkey-cli with ping.

Fixes #

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/9789 **Author:** [@pshankinclarke](https://github.com/pshankinclarke) **Created:** 12/9/2025 **Status:** ✅ Merged **Merged:** 12/13/2025 **Merged by:** [@tremor021](https://github.com/tremor021) **Base:** `main` ← **Head:** `valkey-tls` --- ### 📝 Commits (4) - [`b45b63c`](https://github.com/community-scripts/ProxmoxVE/commit/b45b63c7c6f8144293bda373a98d333f1dc431dc) add optional tls to installer - [`dfe42bd`](https://github.com/community-scripts/ProxmoxVE/commit/dfe42bd003a58fea11508ecf261a13fe2a744976) test tls w/ create_self_signed - [`41ad28d`](https://github.com/community-scripts/ProxmoxVE/commit/41ad28d1d079e7471250a65fed151bd13ec58b5a) improve prompting - [`92a42f9`](https://github.com/community-scripts/ProxmoxVE/commit/92a42f98364847c5db826750e95a48e980079608) revert urls to upstream ### 📊 Changes **1 file changed** (+37 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `install/valkey-install.sh` (+37 -1) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description Automatic configuration of TLS gives users an easy option to encrypt Valkey traffic and protect the generated password without need to manually edit `valkey.conf` or reason about TLS details for each LXC instance. I tested 3 cases (TLS disabled, TLS+TCP, TLS-only), checking `valkey.conf`, the listening ports, and `valkey-cli` with `ping`. ## 🔗 Related Issue Fixes # ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [X] **Tested thoroughly** – Changes work as expected. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [X] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 16:32:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#8275
No description provided.