[PR #9765] [MERGED] fix: always show SSH access dialog in advanced settings #8259

Closed
opened 2026-02-26 16:32:19 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/9765
Author: @MickLesk
Created: 12/7/2025
Status: Merged
Merged: 12/8/2025
Merged by: @MickLesk

Base: mainHead: fix/debian-gpu-autopass


📝 Commits (2)

  • 38ea7db fix: always show SSH access dialog in advanced settings
  • 737e28d merge: resolve conflicts with main branch

📊 Changes

2 files changed (+154 additions, -53 deletions)

View changed files

📝 docs/misc/build.func/BUILD_FUNC_FUNCTIONS_REFERENCE.md (+138 -38)
📝 misc/build.func (+16 -15)

📄 Description

✍️ Description

  • SSH access dialog is now always displayed regardless of password or SSH keys
  • Added step indicator to SSH settings dialogs for consistency
  • configure_ssh_settings() now accepts optional step_info parameter
  • Updated documentation for SSH configuration functions

Fixes #9753

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/9765 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 12/7/2025 **Status:** ✅ Merged **Merged:** 12/8/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `fix/debian-gpu-autopass` --- ### 📝 Commits (2) - [`38ea7db`](https://github.com/community-scripts/ProxmoxVE/commit/38ea7dbba2c2e38f50a6480320848acb174700f5) fix: always show SSH access dialog in advanced settings - [`737e28d`](https://github.com/community-scripts/ProxmoxVE/commit/737e28d223ec080337556c9ff2854ce112d88402) merge: resolve conflicts with main branch ### 📊 Changes **2 files changed** (+154 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `docs/misc/build.func/BUILD_FUNC_FUNCTIONS_REFERENCE.md` (+138 -38) 📝 `misc/build.func` (+16 -15) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description - SSH access dialog is now always displayed regardless of password or SSH keys - Added step indicator to SSH settings dialogs for consistency - configure_ssh_settings() now accepts optional step_info parameter - Updated documentation for SSH configuration functions Fixes #9753 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [ ] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [x] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 16:32:19 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#8259
No description provided.