[PR #9645] [MERGED] Fix kimai.sh update script path typo for local.yaml #8176

Closed
opened 2026-02-26 16:32:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/9645
Author: @Copilot
Created: 12/4/2025
Status: Merged
Merged: 12/4/2025
Merged by: @MickLesk

Base: mainHead: copilot/fix-local-yaml-not-found-error


📝 Commits (2)

  • 573adc2 Initial plan
  • e24955a Fix typo in kimai.sh: correct config path to config/packages/local.yaml

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 ct/kimai.sh (+1 -1)

📄 Description

✍️ Description

The update script referenced config/local.yaml instead of config/packages/local.yaml, causing sed to fail with "No such file or directory" during updates.

Changed:

  • Line 59: config/local.yamlconfig/packages/local.yaml

This aligns with the backup (line 48), restore (line 56), and install script paths.

Link: #6126

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.
Original prompt

This section details on the original issue you should resolve

<issue_title>Kimai local.yml not found error on update command</issue_title>
<issue_description>### Have you read and understood the above guidelines?

yes

🔎 Did you run the script with verbose mode enabled?

Yes, verbose mode was enabled and the output is included below

📜 What is the name of the script you are using?

kimai.sh

📂 What was the exact command used to execute the script?

update

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

📈 Which Proxmox version are you on?

8.4.1

📝 Provide a clear and concise description of the issue.

Step:

sed -i '/^admin_lte:/,/^[^[:space:]]/d' config/local.yaml

there is no local.yaml under config/local.yaml. It must be config/packages/local.yaml or?

🔄 Steps to reproduce the issue.

execute update in container

Paste the full error output (if available).

Updating Kimaised: can't read config/local.yaml: No such file or directory
✖️ in line 59: exit code 2 (Misuse of shell builtins (e.g. syntax error)): while executing command sed -i '/^admin_lte:/,/^[^[:space:]]/d' config/local.yaml

🖼️ Additional context (optional).

No response</issue_description>

<agent_instructions>typo, check against kimai-install.sh</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@MickLesk Yep Typo. Fix in progress. Don't be surprised, I'm handing this over to Copilot because we are currently testing it in the maintainer program, and he is happy (😄) to check such minor details. We check it anyway using the dual control principle.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/9645 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 12/4/2025 **Status:** ✅ Merged **Merged:** 12/4/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `copilot/fix-local-yaml-not-found-error` --- ### 📝 Commits (2) - [`573adc2`](https://github.com/community-scripts/ProxmoxVE/commit/573adc29f4379e4e5c8c61e461b5de3c45679f42) Initial plan - [`e24955a`](https://github.com/community-scripts/ProxmoxVE/commit/e24955a72d6f29046a3cd284d7099acde321ca9b) Fix typo in kimai.sh: correct config path to config/packages/local.yaml ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ct/kimai.sh` (+1 -1) </details> ### 📄 Description ## ✍️ Description The update script referenced `config/local.yaml` instead of `config/packages/local.yaml`, causing `sed` to fail with "No such file or directory" during updates. **Changed:** - Line 59: `config/local.yaml` → `config/packages/local.yaml` This aligns with the backup (line 48), restore (line 56), and install script paths. ## 🔗 Related PR / Issue Link: #6126 ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [X] **Tested thoroughly** – Changes work as expected. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [X] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Kimai local.yml not found error on update command</issue_title> > <issue_description>### ✅ Have you read and understood the above guidelines? > > yes > > ### 🔎 Did you run the script with verbose mode enabled? > > Yes, verbose mode was enabled and the output is included below > > ### 📜 What is the name of the script you are using? > > kimai.sh > > ### 📂 What was the exact command used to execute the script? > > update > > ### ⚙️ What settings are you using? > > - [x] Default Settings > - [ ] Advanced Settings > > ### 🖥️ Which Linux distribution are you using? > > Debian 12 > > ### 📈 Which Proxmox version are you on? > > 8.4.1 > > ### 📝 Provide a clear and concise description of the issue. > > Step: > > sed -i '/^admin_lte:/,/^[^[:space:]]/d' config/local.yaml > > there is no local.yaml under config/local.yaml. It must be config/packages/local.yaml or? > > ### 🔄 Steps to reproduce the issue. > > execute update in container > > ### ❌ Paste the full error output (if available). > > Updating Kimaised: can't read config/local.yaml: No such file or directory > ✖️ in line 59: exit code 2 (Misuse of shell builtins (e.g. syntax error)): while executing command sed -i '/^admin_lte:/,/^[^[:space:]]/d' config/local.yaml > > ### 🖼️ Additional context (optional). > > _No response_</issue_description> > > <agent_instructions>typo, check against kimai-install.sh</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@MickLesk</author><body> > Yep Typo. Fix in progress. Don't be surprised, I'm handing this over to Copilot because we are currently testing it in the maintainer program, and he is happy (😄) to check such minor details. We check it anyway using the dual control principle.</body></comment_new> > </comments> > </details> - Fixes community-scripts/ProxmoxVE#9644 <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 16:32:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#8176
No description provided.