starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 01:06:06 +03:00

[PR #9629] [MERGED] Fix Homebridge update detection for Debian 13 DEB822 format #8164

New issue

Closed

opened 2026-02-26 16:32:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 16:32:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/9629
Author: @Copilot
Created: 12/3/2025
Status: ✅ Merged
Merged: 12/3/2025
Merged by: @MickLesk

Base: main ← Head: copilot/fix-homebridge-update-script

📝 Commits (2)

5a7cb57 Initial plan
80b45d7 Fix Homebridge update detection for Debian 13

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 ct/homebridge.sh (+1 -1)

📄 Description

✍️ Description

Homebridge update script fails on Debian 13 with "No Homebridge Installation Found!" despite package being installed. Root cause: script checks for legacy /etc/apt/sources.list.d/homebridge.list but Debian 13 uses DEB822 format (.sources files).

Change: Replace file-based check with package-based check using dpkg -s homebridge

# Before
if [[ ! -f /etc/apt/sources.list.d/homebridge.list ]]; then

# After  
if ! dpkg -s homebridge >/dev/null 2>&1; then

This aligns with existing patterns in grafana.sh, jellyfin.sh, and wireguard.sh, making detection format-agnostic and more reliable.

Link: N/A (reported via issue tracker)

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.
🆕 New script – A fully functional and tested script or script set.
🌍 Website update – Changes to website-related JSON files or metadata.
🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Original prompt

This section details on the original issue you should resolve

<issue_title>Homebridge not updating using script</issue_title>
<issue_description>### ✅ Have you read and understood the above guidelines?

yes

🔎 Did you run the script with verbose mode enabled?

Yes, verbose mode was enabled and the output is included below

📜 What is the name of the script you are using?

Homebridge

📂 What was the exact command used to execute the script?

update

⚙️ What settings are you using?

Default Settings

Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 13

📈 Which Proxmox version are you on?

9.1.1

📝 Provide a clear and concise description of the issue.

When running the update script, regardless of choosing YES (Simple mode) or YES (Verbose mode), it always ends with: No Homebridge Installation Found!

Homebridge is working as usual, and I've been able to manually update it by stopping the service, run the updates and then starting it again. But the script will not update it at all. Attached is a screenshot of my terminal.

🔄 Steps to reproduce the issue.

Step 1: Inside Homebridge LXC, run update or bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/homebridge.sh)" then select YES.

❌ Paste the full error output (if available).

✖️ No Homebridge Installation Found!

🖼️ Additional context (optional).

No response</issue_description>

<agent_instructions>deb13 should not use .list, maybe an dpkg check? or similar</agent_instructions>

Comments on the Issue (you are @copilot in this section)
@MickLesk in meantime...
apt update
apt install -y homebridge</comment_new>

Fixes community-scripts/ProxmoxVE#9625

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/9629 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 12/3/2025 **Status:** ✅ Merged **Merged:** 12/3/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `copilot/fix-homebridge-update-script` --- ### 📝 Commits (2) - [`5a7cb57`](https://github.com/community-scripts/ProxmoxVE/commit/5a7cb575ec5b62e68355044b27dd67d7317428af) Initial plan - [`80b45d7`](https://github.com/community-scripts/ProxmoxVE/commit/80b45d7f123b65f7a0ba5c06a6c013acad03bbbc) Fix Homebridge update detection for Debian 13 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ct/homebridge.sh` (+1 -1) </details> ### 📄 Description ## ✍️ Description Homebridge update script fails on Debian 13 with "No Homebridge Installation Found!" despite package being installed. Root cause: script checks for legacy `/etc/apt/sources.list.d/homebridge.list` but Debian 13 uses DEB822 format (`.sources` files). **Change:** Replace file-based check with package-based check using `dpkg -s homebridge` ```bash # Before if [[ ! -f /etc/apt/sources.list.d/homebridge.list ]]; then # After if ! dpkg -s homebridge >/dev/null 2>&1; then ``` This aligns with existing patterns in `grafana.sh`, `jellyfin.sh`, and `wireguard.sh`, making detection format-agnostic and more reliable. ## 🔗 Related PR / Issue Link: N/A (reported via issue tracker) ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [X] **Tested thoroughly** – Changes work as expected. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [X] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs.  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Homebridge not updating using script</issue_title> > <issue_description>### ✅ Have you read and understood the above guidelines? > > yes > > ### 🔎 Did you run the script with verbose mode enabled? > > Yes, verbose mode was enabled and the output is included below > > ### 📜 What is the name of the script you are using? > > Homebridge > > ### 📂 What was the exact command used to execute the script? > > update > > ### ⚙️ What settings are you using? > > - [x] Default Settings > - [ ] Advanced Settings > > ### 🖥️ Which Linux distribution are you using? > > Debian 13 > > ### 📈 Which Proxmox version are you on? > > 9.1.1 > > ### 📝 Provide a clear and concise description of the issue. > > When running the update script, regardless of choosing YES (Simple mode) or YES (Verbose mode), it always ends with: No Homebridge Installation Found! > > Homebridge is working as usual, and I've been able to manually update it by stopping the service, run the updates and then starting it again. But the script will not update it at all. Attached is a screenshot of my terminal. > > <img width="904" height="236" alt="Image" src="https://github.com/user-attachments/assets/0008e68c-baa3-49e8-ab27-8e02ee79f34d" /> > > ### 🔄 Steps to reproduce the issue. > > Step 1: Inside Homebridge LXC, run `update` or `bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/homebridge.sh)"` then select YES. > > ### ❌ Paste the full error output (if available). > > ✖️ No Homebridge Installation Found! > > ### 🖼️ Additional context (optional). > > _No response_</issue_description> > > <agent_instructions>deb13 should not use .list, maybe an dpkg check? or similar</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@MickLesk</author><body> > in meantime... > > apt update > apt install -y homebridge</body></comment_new> > </comments> > </details> - Fixes community-scripts/ProxmoxVE#9625  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/community-scripts/ProxmoxVE/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 16:32:00 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#8164

No description provided.

Rows
Columns