starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 17:26:03 +03:00

[PR #9628] [MERGED] Fix service name mismatch between librespeed-rust install and update scripts #8163

New issue

Closed

opened 2026-02-26 16:32:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 16:32:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/9628
Author: @Copilot
Created: 12/3/2025
Status: ✅ Merged
Merged: 12/3/2025
Merged by: @MickLesk

Base: main ← Head: copilot/fix-service-naming-issue

📝 Commits (2)

fb83f4b Initial plan
8f36408 Fix service name inconsistency - use librespeed-rs for both install and update

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 ct/librespeed-rust.sh (+2 -2)
📝 install/librespeed-rust-install.sh (+1 -1)

📄 Description

✍️ Description

The install and update scripts used different systemd service names, causing updates to fail. Install used speedtest_rs, update used librespeed_rs, neither matching the official package's librespeed-rs.service.

Changes:

install/librespeed-rust-install.sh: speedtest_rs → librespeed-rs
ct/librespeed-rust.sh: librespeed_rs → librespeed-rs (stop/start commands)

Both scripts now use librespeed-rs, matching the debian package from librespeed/speedtest-rust.

Link: #4842

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.
🆕 New script – A fully functional and tested script or script set.
🌍 Website update – Changes to website-related JSON files or metadata.
🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Original prompt

This section details on the original issue you should resolve

<issue_title>Librespeed-rust install and update scripts use different .service names</issue_title>
<issue_description>### ✅ Have you read and understood the above guidelines?

yes

🔎 Did you run the script with verbose mode enabled?

Yes, verbose mode was enabled and the output is included below

📜 What is the name of the script you are using?

Librespeed Rust

📂 What was the exact command used to execute the script?

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/librespeed-rust.sh)"

⚙️ What settings are you using?

Default Settings

Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

📈 Which Proxmox version are you on?

8.4.14

📝 Provide a clear and concise description of the issue.

The installation script and the update script use different names for the systemd service. In the installation script, it is set up as:
systemctl enable -q --now speedtest_rs
While the update script refers to:
systemctl start librespeed_rs
This causes a failure while updating. Curiously both these names are different than the librespeed-rs library's default system name which is
sudo systemctl enable librespeed-rs.service
🔄 Steps to reproduce the issue.

You need to have a librespeed-rs installed. Mine is version 1.3.8.

Run the update script in the container: bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/librespeed-rust.sh)"

Notice the error.

❌ Paste the full error output (if available).
  ✔️   Update available: librespeed-rust 1.3.8 → 1.4.0
  ⏳   Stopping ServicesFailed to stop librespeed_rs.service: Unit librespeed_rs.service not loaded.

[ERROR] in line 33: exit code 0: while executing command systemctl stop librespeed_rs
🖼️ Additional context (optional).

No response</issue_description>

<agent_instructions>Servicenames are different in update/install, fix it</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes community-scripts/ProxmoxVE#9626

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/9628 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 12/3/2025 **Status:** ✅ Merged **Merged:** 12/3/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `copilot/fix-service-naming-issue` --- ### 📝 Commits (2) - [`fb83f4b`](https://github.com/community-scripts/ProxmoxVE/commit/fb83f4be1b630a92f39650c01479a9dcb471f017) Initial plan - [`8f36408`](https://github.com/community-scripts/ProxmoxVE/commit/8f36408d8418e2395d49190628506d41c95d656d) Fix service name inconsistency - use librespeed-rs for both install and update ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `ct/librespeed-rust.sh` (+2 -2) 📝 `install/librespeed-rust-install.sh` (+1 -1) </details> ### 📄 Description ## ✍️ Description The install and update scripts used different systemd service names, causing updates to fail. Install used `speedtest_rs`, update used `librespeed_rs`, neither matching the official package's `librespeed-rs.service`. **Changes:** - `install/librespeed-rust-install.sh`: `speedtest_rs` → `librespeed-rs` - `ct/librespeed-rust.sh`: `librespeed_rs` → `librespeed-rs` (stop/start commands) Both scripts now use `librespeed-rs`, matching the debian package from librespeed/speedtest-rust. ## 🔗 Related PR / Issue Link: #4842 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs.  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Librespeed-rust install and update scripts use different .service names</issue_title> > <issue_description>### ✅ Have you read and understood the above guidelines? > > yes > > ### 🔎 Did you run the script with verbose mode enabled? > > Yes, verbose mode was enabled and the output is included below > > ### 📜 What is the name of the script you are using? > > Librespeed Rust > > ### 📂 What was the exact command used to execute the script? > > bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/librespeed-rust.sh)" > > ### ⚙️ What settings are you using? > > - [x] Default Settings > - [ ] Advanced Settings > > ### 🖥️ Which Linux distribution are you using? > > Debian 12 > > ### 📈 Which Proxmox version are you on? > > 8.4.14 > > ### 📝 Provide a clear and concise description of the issue. > > The installation script and the update script use different names for the systemd service. In the installation script, it is set up as: > > ```sh > systemctl enable -q --now speedtest_rs > ``` > > While the update script refers to: > > ```sh > systemctl start librespeed_rs > ``` > > This causes a failure while updating. Curiously both these names are different than the [librespeed-rs library's default system name](https://github.com/librespeed/speedtest-rust/wiki/Installation) which is > > ```sh > sudo systemctl enable librespeed-rs.service > ``` > > ### 🔄 Steps to reproduce the issue. > > 1. You need to have a librespeed-rs installed. Mine is version 1.3.8. > 2. Run the update script in the container: `bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/librespeed-rust.sh)"` > 3. Notice the error. > > ### ❌ Paste the full error output (if available). > ```shell > ✔️ Update available: librespeed-rust 1.3.8 → 1.4.0 > ⏳ Stopping ServicesFailed to stop librespeed_rs.service: Unit librespeed_rs.service not loaded. > > [ERROR] in line 33: exit code 0: while executing command systemctl stop librespeed_rs > ``` > > ### 🖼️ Additional context (optional). > > _No response_</issue_description> > > <agent_instructions>Servicenames are different in update/install, fix it</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> - Fixes community-scripts/ProxmoxVE#9626  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 16:32:00 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#8163

No description provided.

Rows
Columns