starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 01:06:06 +03:00

[PR #9503] [MERGED] Fix duplicate ORIGIN in .env for OpenArchiver install script #8074

New issue

Closed

opened 2026-02-26 16:31:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 16:31:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/9503
Author: @Copilot
Created: 11/29/2025
Status: ✅ Merged
Merged: 11/29/2025
Merged by: @MickLesk

Base: main ← Head: copilot/fix-duplicate-origin-in-env

📝 Commits (2)

adbd370 Initial plan
9bf2cd0 Fix duplicate ORIGIN in .env for OpenArchiver install script

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 install/open-archiver-install.sh (+1 -1)

📄 Description

✍️ Description

OpenArchiver's .env.example now includes an ORIGIN variable (since this commit). The install script was appending a second ORIGIN line, causing the user-editable value at line 11 to be silently overridden by the duplicate at the end.

Changed from appending to replacing, consistent with all other env var handling in the script:

# Before
echo "ORIGIN=http://$IP_ADDR:3000" >>/opt/openarchiver/.env

# After
sed -i "s|^ORIGIN=.*|ORIGIN=http://$IP_ADDR:3000|g" /opt/openarchiver/.env

Link: #2568

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.
🆕 New script – A fully functional and tested script or script set.
🌍 Website update – Changes to website-related JSON files or metadata.
🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Original prompt

This section details on the original issue you should resolve

<issue_title>OpenArchiver - Duplicate ORIGIN in .env</issue_title>
<issue_description>### ✅ Have you read and understood the above guidelines?

yes

🔎 Did you run the script with verbose mode enabled?

Yes, verbose mode was enabled and the output is included below

📜 What is the name of the script you are using?

OpenArchiver

📂 What was the exact command used to execute the script?

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/open-archiver.sh)"

⚙️ What settings are you using?

Default Settings

Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 13

📈 Which Proxmox version are you on?

8

📝 Provide a clear and concise description of the issue.

The install process for OpenArchiver appends a value for ORIGIN.

echo "ORIGIN=http://$IP_ADDR:3000" >>/opt/openarchiver/.env

But there is a ORIGIN in the .env.example in line 11 since the last release of OpenArchiver, see this commit.

🔄 Steps to reproduce the issue.

Running the installer
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/open-archiver.sh)"
❌ Paste the full error output (if available).

No error will appear, but when you change the ORIGIN in line 11, it will be overwritten with the ORIGIN in the last line.

🖼️ Additional context (optional).

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes community-scripts/ProxmoxVE#9502

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/9503 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 11/29/2025 **Status:** ✅ Merged **Merged:** 11/29/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `copilot/fix-duplicate-origin-in-env` --- ### 📝 Commits (2) - [`adbd370`](https://github.com/community-scripts/ProxmoxVE/commit/adbd37056b52a204c9edb3ac504332386c034475) Initial plan - [`9bf2cd0`](https://github.com/community-scripts/ProxmoxVE/commit/9bf2cd090ccdb924471599ac8e864bb55e0f3267) Fix duplicate ORIGIN in .env for OpenArchiver install script ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `install/open-archiver-install.sh` (+1 -1) </details> ### 📄 Description ## ✍️ Description OpenArchiver's `.env.example` now includes an `ORIGIN` variable (since [this commit](https://github.com/LogicLabs-OU/OpenArchiver/commit/6e1ebbbfd7e834a7e191e1e55214ef3ac94195ee)). The install script was appending a second `ORIGIN` line, causing the user-editable value at line 11 to be silently overridden by the duplicate at the end. Changed from appending to replacing, consistent with all other env var handling in the script: ```bash # Before echo "ORIGIN=http://$IP_ADDR:3000" >>/opt/openarchiver/.env # After sed -i "s|^ORIGIN=.*|ORIGIN=http://$IP_ADDR:3000|g" /opt/openarchiver/.env ``` ## 🔗 Related PR / Issue Link: #2568 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs.  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>OpenArchiver - Duplicate ORIGIN in .env</issue_title> > <issue_description>### ✅ Have you read and understood the above guidelines? > > yes > > ### 🔎 Did you run the script with verbose mode enabled? > > Yes, verbose mode was enabled and the output is included below > > ### 📜 What is the name of the script you are using? > > OpenArchiver > > ### 📂 What was the exact command used to execute the script? > > bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/open-archiver.sh)" > > ### ⚙️ What settings are you using? > > - [x] Default Settings > - [ ] Advanced Settings > > ### 🖥️ Which Linux distribution are you using? > > Debian 13 > > ### 📈 Which Proxmox version are you on? > > 8 > > ### 📝 Provide a clear and concise description of the issue. > > The [install process for OpenArchiver ](https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/install/open-archiver-install.sh) appends a value for `ORIGIN`. > > `echo "ORIGIN=http://$IP_ADDR:3000" >>/opt/openarchiver/.env` > > But there is a `ORIGIN` in the `.env.example` in line 11 since the last release of OpenArchiver, see [this commit](https://github.com/LogicLabs-OU/OpenArchiver/commit/6e1ebbbfd7e834a7e191e1e55214ef3ac94195ee). > > ### 🔄 Steps to reproduce the issue. > > Running the installer > > ``` > bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/open-archiver.sh)" > ``` > > ### ❌ Paste the full error output (if available). > > No error will appear, but when you change the `ORIGIN` in line 11, it will be overwritten with the `ORIGIN` in the last line. > > ### 🖼️ Additional context (optional). > > _No response_</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> - Fixes community-scripts/ProxmoxVE#9502  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/community-scripts/ProxmoxVE/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 16:31:42 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#8074

No description provided.

Rows
Columns