[PR #9060] [MERGED] Refactor: openHAB #7804

Closed
opened 2026-02-26 16:30:46 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/9060
Author: @MickLesk
Created: 11/11/2025
Status: Merged
Merged: 11/11/2025
Merged by: @michelroegl-brunner

Base: mainHead: openhab


📝 Commits (4)

  • 11de9c9 Refactor: openHAB
  • 5329583 Update openhab-install.sh
  • 8b853e1 Apply suggestion from @tremor021
  • 8415f0c Apply suggestion from @tremor021

📊 Changes

2 files changed (+30 additions, -35 deletions)

View changed files

📝 ct/openhab.sh (+11 -11)
📝 install/openhab-install.sh (+19 -24)

📄 Description

✍️ Description

refactor openHAB
added folders, because openHAB apt installer dont know mkdir, lol

Link: #9056

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/9060 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 11/11/2025 **Status:** ✅ Merged **Merged:** 11/11/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `openhab` --- ### 📝 Commits (4) - [`11de9c9`](https://github.com/community-scripts/ProxmoxVE/commit/11de9c93caa052ae847fe1a199b4d901d3146892) Refactor: openHAB - [`5329583`](https://github.com/community-scripts/ProxmoxVE/commit/53295830cf32834deee805af48502e20d29d9e7f) Update openhab-install.sh - [`8b853e1`](https://github.com/community-scripts/ProxmoxVE/commit/8b853e129dde36e45403ad89547789209fab0658) Apply suggestion from @tremor021 - [`8415f0c`](https://github.com/community-scripts/ProxmoxVE/commit/8415f0c65b70b3cab1f1685f70621c97cd324392) Apply suggestion from @tremor021 ### 📊 Changes **2 files changed** (+30 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `ct/openhab.sh` (+11 -11) 📝 `install/openhab-install.sh` (+19 -24) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description refactor openHAB added folders, because openHAB apt installer dont know mkdir, lol ## 🔗 Related PR / Issue Link: #9056 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [x] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 16:30:46 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#7804
No description provided.