[PR #8757] [MERGED] Standardize update success messages in scripts #7620

Closed
opened 2026-02-26 15:35:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/8757
Author: @MickLesk
Created: 10/30/2025
Status: Merged
Merged: 10/30/2025
Merged by: @tremor021

Base: mainHead: harmonize_updateend_message


📝 Commits (9)

📊 Changes

357 files changed (+1286 additions, -1207 deletions)

View changed files

📝 ct/2fauth.sh (+1 -1)
📝 ct/actualbudget.sh (+3 -2)
📝 ct/adventurelog.sh (+1 -1)
📝 ct/agentdvr.sh (+3 -4)
📝 ct/alpine-adguard.sh (+1 -0)
📝 ct/alpine-bitmagnet.sh (+2 -2)
📝 ct/alpine-caddy.sh (+1 -0)
📝 ct/alpine-docker.sh (+1 -0)
📝 ct/alpine-forgejo.sh (+1 -0)
📝 ct/alpine-garage.sh (+1 -1)
📝 ct/alpine-gatus.sh (+2 -2)
📝 ct/alpine-gitea.sh (+1 -0)
📝 ct/alpine-grafana.sh (+3 -0)
📝 ct/alpine-it-tools.sh (+2 -2)
📝 ct/alpine-komodo.sh (+7 -6)
📝 ct/alpine-mariadb.sh (+1 -0)
📝 ct/alpine-node-red.sh (+1 -0)
📝 ct/alpine-postgresql.sh (+1 -0)
📝 ct/alpine-prometheus.sh (+1 -0)
📝 ct/alpine-rclone.sh (+2 -2)

...and 80 more files

📄 Description

✍️ Description

1.) Replaces various forms of 'Updated Successfully' with 'Update Successfully!' across multiple container setup scripts for consistency. Also includes minor formatting and message improvements in several scripts.

2.) Replaces old "Stopping APP" to "Stopping Service"

3.) minor bugfixes & improvements

=> No Function Changes, No Core Changes, No Script-Logic Changes, only Typo / Sentences

Link: #

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/8757 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 10/30/2025 **Status:** ✅ Merged **Merged:** 10/30/2025 **Merged by:** [@tremor021](https://github.com/tremor021) **Base:** `main` ← **Head:** `harmonize_updateend_message` --- ### 📝 Commits (9) - [`1fbf324`](https://github.com/community-scripts/ProxmoxVE/commit/1fbf32443aa4d401a9219470c0d1b308297466b3) Standardize update success messages in scripts - [`bb8102f`](https://github.com/community-scripts/ProxmoxVE/commit/bb8102f9c666e3fbeb417614e85971352c865099) Standardize update success messages in scripts - [`1b5cf42`](https://github.com/community-scripts/ProxmoxVE/commit/1b5cf420ec112ec5a32e9a5cdbda89529b4b7fa7) Merge branch 'main' into harmonize_updateend_message - [`8c62b63`](https://github.com/community-scripts/ProxmoxVE/commit/8c62b63944e3d28a33f43e097c3c0e4d703ef1d7) Standardize update success message casing - [`85fd357`](https://github.com/community-scripts/ProxmoxVE/commit/85fd357a022f0e5172ea43606f45f03e658244ed) Merge branch 'harmonize_updateend_message' of https://github.com/community-scripts/ProxmoxVE into harmonize_updateend_message - [`bcc57da`](https://github.com/community-scripts/ProxmoxVE/commit/bcc57dad4371e81805bb89c4e72c1f45d7234ef8) Remove exit status 1 from error exits in update scripts - [`2d18a58`](https://github.com/community-scripts/ProxmoxVE/commit/2d18a589f76e6ee498fd7576961ada4085469d70) Use explicit exit code in update_script functions - [`0ec3641`](https://github.com/community-scripts/ProxmoxVE/commit/0ec364120104cf4bc3db8a507c40a8bbc780811b) Update zerotier-one.sh - [`d135aae`](https://github.com/community-scripts/ProxmoxVE/commit/d135aae1a8e545e317ddfdda1402399d5bdeb727) Rebase Commit ### 📊 Changes **357 files changed** (+1286 additions, -1207 deletions) <details> <summary>View changed files</summary> 📝 `ct/2fauth.sh` (+1 -1) 📝 `ct/actualbudget.sh` (+3 -2) 📝 `ct/adventurelog.sh` (+1 -1) 📝 `ct/agentdvr.sh` (+3 -4) 📝 `ct/alpine-adguard.sh` (+1 -0) 📝 `ct/alpine-bitmagnet.sh` (+2 -2) 📝 `ct/alpine-caddy.sh` (+1 -0) 📝 `ct/alpine-docker.sh` (+1 -0) 📝 `ct/alpine-forgejo.sh` (+1 -0) 📝 `ct/alpine-garage.sh` (+1 -1) 📝 `ct/alpine-gatus.sh` (+2 -2) 📝 `ct/alpine-gitea.sh` (+1 -0) 📝 `ct/alpine-grafana.sh` (+3 -0) 📝 `ct/alpine-it-tools.sh` (+2 -2) 📝 `ct/alpine-komodo.sh` (+7 -6) 📝 `ct/alpine-mariadb.sh` (+1 -0) 📝 `ct/alpine-node-red.sh` (+1 -0) 📝 `ct/alpine-postgresql.sh` (+1 -0) 📝 `ct/alpine-prometheus.sh` (+1 -0) 📝 `ct/alpine-rclone.sh` (+2 -2) _...and 80 more files_ </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description 1.) Replaces various forms of 'Updated Successfully' with 'Update Successfully!' across multiple container setup scripts for consistency. Also includes minor formatting and message improvements in several scripts. 2.) Replaces old "Stopping APP" to "Stopping Service" 3.) minor bugfixes & improvements => No Function Changes, No Core Changes, No Script-Logic Changes, only Typo / Sentences ## 🔗 Related PR / Issue Link: # ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [x] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 15:35:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#7620
No description provided.