[PR #7820] [MERGED] ElementSynapse: add note for Bridge Install Methods #7083

Closed
opened 2026-02-26 15:33:58 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/7820
Author: @MickLesk
Created: 9/23/2025
Status: Merged
Merged: 9/23/2025
Merged by: @michelroegl-brunner

Base: mainHead: MickLesk-patch-7


📝 Commits (1)

  • d676e76 ElementSynapse: add note for Bridge Install Methods

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 frontend/public/json/elementsynapse.json (+4 -0)

📄 Description

✍️ Description

add an note for install bridges for element synapse, reason:
I just reviewed this request and I think integrating bridges directly into the Synapse script would massively bloat it. Each bridge has different dependencies, configs, and use cases, which would easily add 200–400 extra lines of code. That would make the script harder to maintain in the long run.
Instead, I’d suggest either writing a separate guide or adding a link on the website pointing to the official bridge documentation. This keeps the main script lean and maintainable, while still giving users a clear path if they want to set up bridges like WhatsApp, Signal, or Discord.

Link: #7073

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/7820 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 9/23/2025 **Status:** ✅ Merged **Merged:** 9/23/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `MickLesk-patch-7` --- ### 📝 Commits (1) - [`d676e76`](https://github.com/community-scripts/ProxmoxVE/commit/d676e762cd0fd7cc1aeacbf33542175fc7df0621) ElementSynapse: add note for Bridge Install Methods ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `frontend/public/json/elementsynapse.json` (+4 -0) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description add an note for install bridges for element synapse, **reason**: _I just reviewed this request and I think integrating bridges directly into the Synapse script would massively bloat it. Each bridge has different dependencies, configs, and use cases, which would easily add 200–400 extra lines of code. That would make the script harder to maintain in the long run. Instead, I’d suggest either writing a separate guide or adding a link on the website pointing to the official bridge documentation. This keeps the main script lean and maintainable, while still giving users a clear path if they want to set up bridges like WhatsApp, Signal, or Discord._ ## 🔗 Related PR / Issue Link: #7073 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [x] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 15:33:58 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#7083
No description provided.