[PR #6734] [CLOSED] fix(pulse): add missing version file creation #6354

Closed
opened 2026-02-26 15:31:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/6734
Author: @rcourtman
Created: 8/10/2025
Status: Closed

Base: mainHead: fix-pulse-version-tracking


📝 Commits (1)

  • a5cacbf fix(pulse): add missing version file creation for update tracking

📊 Changes

2 files changed (+3 additions, -0 deletions)

View changed files

📝 ct/pulse.sh (+1 -0)
📝 install/pulse-install.sh (+2 -0)

📄 Description

✍️ Description

Fixes broken update mechanism for Pulse. The version file (~/.pulse) was never created during installation or update, causing users to get stuck on older versions with 'Old Installation Found!' errors.

What this fixes:

  • Users stuck on v4.0.7 unable to update
  • 'Old Installation Found!' error during updates
  • Version tracking not working

Changes:

  • Added version file creation after installation
  • Added version file update after successful updates
  • Minimal code changes following existing patterns

Fixes user report: rcourtman/Pulse#276

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Testing performed:

  • Fresh installation creates version file
  • Update mechanism now works correctly
  • Version file properly tracks current version

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/6734 **Author:** [@rcourtman](https://github.com/rcourtman) **Created:** 8/10/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-pulse-version-tracking` --- ### 📝 Commits (1) - [`a5cacbf`](https://github.com/community-scripts/ProxmoxVE/commit/a5cacbffc9cb3b6e7b859015e5dee687b9cdbb26) fix(pulse): add missing version file creation for update tracking ### 📊 Changes **2 files changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `ct/pulse.sh` (+1 -0) 📝 `install/pulse-install.sh` (+2 -0) </details> ### 📄 Description ## ✍️ Description Fixes broken update mechanism for Pulse. The version file (~/.pulse) was never created during installation or update, causing users to get stuck on older versions with 'Old Installation Found\!' errors. ### What this fixes: - Users stuck on v4.0.7 unable to update - 'Old Installation Found\!' error during updates - Version tracking not working ### Changes: - Added version file creation after installation - Added version file update after successful updates - Minimal code changes following existing patterns ## 🔗 Related PR / Issue Fixes user report: rcourtman/Pulse#276 ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [X] **Tested thoroughly** – Changes work as expected. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [X] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. ### Testing performed: - ✅ Fresh installation creates version file - ✅ Update mechanism now works correctly - ✅ Version file properly tracks current version --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 15:31:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#6354
No description provided.