[PR #6648] [MERGED] Karakeep: workaround/fix for #6593 #6299

Closed
opened 2026-02-26 15:31:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/6648
Author: @vhsdream
Created: 8/8/2025
Status: Merged
Merged: 8/8/2025
Merged by: @CrazyWolf13

Base: mainHead: karakeep


📝 Commits (1)

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 ct/karakeep.sh (+1 -1)
📝 install/karakeep-install.sh (+1 -1)

📄 Description

✍️ Description

  • This PR fixes the DB migration failure due to the DATA_DIR variable being surrounded by quotes in the env file. Previously this was not an issue because we exported the value without grabbing it from the env file. Now that it is user-configurable and considering that the value in the env file has been surrounded by quotes since the start, when we grab the value we need to ensure the quotes are removed.
  • The install script has been updated to not use quotes and the new parsing command in the update function has been tested with both quoted and unquoted values.

Link: #6593

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/6648 **Author:** [@vhsdream](https://github.com/vhsdream) **Created:** 8/8/2025 **Status:** ✅ Merged **Merged:** 8/8/2025 **Merged by:** [@CrazyWolf13](https://github.com/CrazyWolf13) **Base:** `main` ← **Head:** `karakeep` --- ### 📝 Commits (1) - [`ed8e632`](https://github.com/community-scripts/ProxmoxVE/commit/ed8e63249209d7412b827bb82c11c7526cef68ab) Karakeep: workaround/fix for #6593 ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `ct/karakeep.sh` (+1 -1) 📝 `install/karakeep-install.sh` (+1 -1) </details> ### 📄 Description ## ✍️ Description - This PR fixes the DB migration failure due to the `DATA_DIR` variable being surrounded by quotes in the env file. Previously this was not an issue because we exported the value without grabbing it from the env file. Now that it is user-configurable and considering that the value in the env file has been surrounded by quotes since the start, when we grab the value we need to ensure the quotes are removed. - The install script has been updated to not use quotes and the new parsing command in the update function has been tested with both quoted and unquoted values. ## 🔗 Related PR / Issue Link: #6593 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 15:31:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#6299
No description provided.