[PR #6098] [MERGED] pve-post-installer: remove Nag-File if already exist #5948

Closed
opened 2026-02-26 14:35:46 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/6098
Author: @luckman212
Created: 7/20/2025
Status: Merged
Merged: 7/21/2025
Merged by: @tremor021

Base: mainHead: pve-nonag-patch-2


📝 Commits (1)

📊 Changes

1 file changed (+17 additions, -18 deletions)

View changed files

📝 tools/pve/post-pve-install.sh (+17 -18)

📄 Description

✍️ Description

This updated version of #6087 does not compare hashes or file contents of the dpkg hook script. It simply overwrites the script if "yes" is chosen, or removes the hook script if "no" is selected.

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/6098 **Author:** [@luckman212](https://github.com/luckman212) **Created:** 7/20/2025 **Status:** ✅ Merged **Merged:** 7/21/2025 **Merged by:** [@tremor021](https://github.com/tremor021) **Base:** `main` ← **Head:** `pve-nonag-patch-2` --- ### 📝 Commits (1) - [`7fe8702`](https://github.com/community-scripts/ProxmoxVE/commit/7fe8702ad37caa25421b384234593d1ad08aa8e1) alternate fix for #6087 ### 📊 Changes **1 file changed** (+17 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `tools/pve/post-pve-install.sh` (+17 -18) </details> ### 📄 Description ## ✍️ Description This updated version of #6087 does not compare hashes or file contents of the dpkg hook script. It simply overwrites the script if "yes" is chosen, or removes the hook script if "no" is selected. ## 🔗 Related PR / Issues - #6078 - #6087 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [x] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 14:35:46 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#5948
No description provided.