[PR #5791] [MERGED] IP-Tag: Optimizations / Guide / Manual Execution #5758

Closed
opened 2026-02-26 14:35:09 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/5791
Author: @MickLesk
Created: 7/7/2025
Status: Merged
Merged: 7/7/2025
Merged by: @MickLesk

Base: mainHead: ip_tag_optimization


📝 Commits (3)

  • 8ec6ddc IP-Tag: Optimizations / Guide / Manual Execution
  • 465ea54 warning > info
  • 80744bf Update add-iptag.json

📊 Changes

2 files changed (+33 additions, -10 deletions)

View changed files

📝 frontend/public/json/add-iptag.json (+5 -1)
📝 tools/pve/add-iptag.sh (+28 -9)

📄 Description

✍️ Description

  • Improved performance defaults in iptag.conf:
    • Reduced MAX_PARALLEL_LXC_CHECKS and LXC_BATCH_SIZE
    • Increased TTLs for LXC/VM IP/status cache
  • Systemd service optimization:
    • Changed Restart=alwaysRestart=on-failure
    • Increased RestartSec=110 to avoid restart loops
  • Main loop now persistent:
    • Added while true loop in main() to avoid immediate exit
  • Manual execution support:
    • Added /usr/local/bin/iptag-run
      • Allows users to execute IP-Tag once manually without running the background service

Link: #5701

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/5791 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 7/7/2025 **Status:** ✅ Merged **Merged:** 7/7/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `ip_tag_optimization` --- ### 📝 Commits (3) - [`8ec6ddc`](https://github.com/community-scripts/ProxmoxVE/commit/8ec6ddcf74737d8dbd947d47b38e8c77414f6e03) IP-Tag: Optimizations / Guide / Manual Execution - [`465ea54`](https://github.com/community-scripts/ProxmoxVE/commit/465ea54d0429e8b6c312b2f73598cabc1161974b) warning > info - [`80744bf`](https://github.com/community-scripts/ProxmoxVE/commit/80744bff1061509172f6e2a4d38232679ac85e7f) Update add-iptag.json ### 📊 Changes **2 files changed** (+33 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `frontend/public/json/add-iptag.json` (+5 -1) 📝 `tools/pve/add-iptag.sh` (+28 -9) </details> ### 📄 Description ## ✍️ Description - **Improved performance defaults** in `iptag.conf`: - Reduced `MAX_PARALLEL_LXC_CHECKS` and `LXC_BATCH_SIZE` - Increased TTLs for LXC/VM IP/status cache - **Systemd service optimization**: - Changed `Restart=always` → `Restart=on-failure` - Increased `RestartSec=1` → `10` to avoid restart loops - **Main loop now persistent**: - Added `while true` loop in `main()` to avoid immediate exit - **Manual execution support**: - Added `/usr/local/bin/iptag-run` - Allows users to execute IP-Tag once manually without running the background service ## 🔗 Related PR / Issue Link: #5701 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 14:35:09 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#5758
No description provided.