starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 17:26:03 +03:00

[PR #5422] [MERGED] [core]: Improve GitHub release fetch robustness with split timeouts and retry logic #5516

New issue

Closed

opened 2026-02-26 14:34:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 14:34:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/5422
Author: @MickLesk
Created: 6/24/2025
Status: ✅ Merged
Merged: 6/24/2025
Merged by: @michelroegl-brunner

Base: main ← Head: increase_timeout

📝 Commits (1)

7e18449 Update tools.func

📊 Changes

1 file changed (+24 additions, -13 deletions)

View changed files

📝 misc/tools.func (+24 -13)

📄 Description

✍️ Description

This PR improves the robustness of the fetch_and_deploy_gh_release function by:

Splitting curl timeout handling:
- API fetch now uses --connect-timeout 5 --max-time 30
- Asset downloads use --connect-timeout 15 --max-time 900
Adding retry logic for GitHub API metadata fetch (3 attempts with 2s delay)
Preventing unnecessary download aborts for large prebuilds (e.g. Immich tarballs >150MB)
No functional changes to the function signature or behavior

These improvements make the function more resilient in environments with slow or unstable networks.

#5387

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

🐞 Bug fix
✨ New feature (non-breaking robustness enhancement)
💥 Breaking change
🆕 New script
🌍 Website update
🔧 Refactoring / Code Cleanup

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/5422 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 6/24/2025 **Status:** ✅ Merged **Merged:** 6/24/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `increase_timeout` --- ### 📝 Commits (1) - [`7e18449`](https://github.com/community-scripts/ProxmoxVE/commit/7e184490c6f5c270afb24e040f6b4275339d9118) Update tools.func ### 📊 Changes **1 file changed** (+24 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `misc/tools.func` (+24 -13) </details> ### 📄 Description ## ✍️ Description This PR improves the robustness of the `fetch_and_deploy_gh_release` function by: - Splitting `curl` timeout handling: - API fetch now uses `--connect-timeout 5 --max-time 30` - Asset downloads use `--connect-timeout 15 --max-time 900` - Adding retry logic for GitHub API metadata fetch (3 attempts with 2s delay) - Preventing unnecessary download aborts for large prebuilds (e.g. Immich tarballs >150MB) - No functional changes to the function signature or behavior These improvements make the function more resilient in environments with slow or unstable networks. ## 🔗 Related PR / Issue #5387 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** - [x] ✨ **New feature** (non-breaking robustness enhancement) - [ ] 💥 **Breaking change** - [ ] 🆕 **New script** - [ ] 🌍 **Website update** - [ ] 🔧 **Refactoring / Code Cleanup** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 14:34:24 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 14:34:37 +03:00

[PR #5535] [MERGED] ONLYOFFICE: Update install script to manually create RabbitMQ user #5590

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#5516

No description provided.

Rows
Columns