[PR #5278] [MERGED] [core]: Feature - Check Quorum Status in create_lxc to prevent issues #5428

Closed
opened 2026-02-26 14:34:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/5278
Author: @MickLesk
Created: 6/19/2025
Status: Merged
Merged: 6/19/2025
Merged by: @MickLesk

Base: mainHead: feature_create_lxc_quorum_status


📝 Commits (1)

📊 Changes

5 files changed (+64 additions, -18 deletions)

View changed files

📝 .github/CONTRIBUTOR_AND_GUIDES/CODE-AUDIT.md (+2 -2)
📝 .github/autolabeler-config.json (+48 -13)
📝 .github/workflows/validate-filenames.yml (+2 -2)
📝 misc/build.func (+1 -1)
📝 misc/create_lxc.sh (+11 -0)

📄 Description

✍️ Description

In a Proxmox VE cluster, it is not allowed to make changes to the cluster configuration (such as creating a CT or VM) if the cluster is not “quorate”. This means: If the cluster does not reach a quorum (e.g. with a 2-node cluster and only one node is online), actions such as pct create, qm create, etc. are not allowed - even if you are directly on the working node.

In the same stage, i move "create_lxc" from ct-Folder to misc-Folder

Related to this:
=> https://github.com/community-scripts/ProxmoxVE/discussions/5245

if an cluster (node) is offline, create_lxc failed, because proxmox need an quorum for clusters.
[ERROR] in line 1127 #5169
=> User-Feedback: https://github.com/community-scripts/ProxmoxVE/discussions/5169#discussioncomment-13517784

Output:
image

Link: #5169 #5245

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/5278 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 6/19/2025 **Status:** ✅ Merged **Merged:** 6/19/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `feature_create_lxc_quorum_status` --- ### 📝 Commits (1) - [`ac7406a`](https://github.com/community-scripts/ProxmoxVE/commit/ac7406a1e01db2a7d76db4a86649f3006e54716b) Feat: Quorum Status ### 📊 Changes **5 files changed** (+64 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `.github/CONTRIBUTOR_AND_GUIDES/CODE-AUDIT.md` (+2 -2) 📝 `.github/autolabeler-config.json` (+48 -13) 📝 `.github/workflows/validate-filenames.yml` (+2 -2) 📝 `misc/build.func` (+1 -1) 📝 `misc/create_lxc.sh` (+11 -0) </details> ### 📄 Description ## ✍️ Description In a Proxmox VE cluster, it is not allowed to make changes to the cluster configuration (such as creating a CT or VM) if the cluster is not “quorate”. This means: If the cluster does not reach a quorum (e.g. with a 2-node cluster and only one node is online), actions such as pct create, qm create, etc. are not allowed - even if you are directly on the working node. In the same stage, i move "create_lxc" from ct-Folder to misc-Folder Related to this: => https://github.com/community-scripts/ProxmoxVE/discussions/5245 if an cluster (node) is offline, create_lxc failed, because proxmox need an quorum for clusters. [ERROR] in line 1127 #5169 => User-Feedback: https://github.com/community-scripts/ProxmoxVE/discussions/5169#discussioncomment-13517784 Output: ![image](https://github.com/user-attachments/assets/10eddaff-421a-4f71-9d99-2cb6f0556acf) ## 🔗 Related PR / Issue Link: #5169 #5245 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [x] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 14:34:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#5428
No description provided.