[PR #5162] [MERGED] Kasm: Storing Creds Fix #5350

Closed
opened 2026-02-26 14:33:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/5162
Author: @omiinaya
Created: 6/15/2025
Status: Merged
Merged: 6/16/2025
Merged by: @michelroegl-brunner

Base: mainHead: kasm-cred-fix


📝 Commits (3)

  • 9a681e1 this should do it.
  • 8718804 Update kasm-install.sh
  • bcae100 Merge branch 'main' into kasm-cred-fix

📊 Changes

1 file changed (+13 additions, -5 deletions)

View changed files

📝 install/kasm-install.sh (+13 -5)

📄 Description

✍️ Description

Fixed a bug where the credential files would not be stored if verbose mode wasn't selected.

Link: #

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/5162 **Author:** [@omiinaya](https://github.com/omiinaya) **Created:** 6/15/2025 **Status:** ✅ Merged **Merged:** 6/16/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `kasm-cred-fix` --- ### 📝 Commits (3) - [`9a681e1`](https://github.com/community-scripts/ProxmoxVE/commit/9a681e1824b0940d8771d3a528e4e9f089da35f7) this should do it. - [`8718804`](https://github.com/community-scripts/ProxmoxVE/commit/87188040e19f842aa0f32cdb6f20b93f2510baeb) Update kasm-install.sh - [`bcae100`](https://github.com/community-scripts/ProxmoxVE/commit/bcae100c5e522c21e94031de7beb2d7ec3e8052b) Merge branch 'main' into kasm-cred-fix ### 📊 Changes **1 file changed** (+13 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `install/kasm-install.sh` (+13 -5) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description Fixed a bug where the credential files would not be stored if verbose mode wasn't selected. ## 🔗 Related PR / Issue Link: # ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 14:33:52 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#5350
No description provided.