[PR #4954] [MERGED] [refactor] Seelf #5213

Closed
opened 2026-02-26 14:33:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/4954
Author: @tremor021
Created: 6/3/2025
Status: Merged
Merged: 6/4/2025
Merged by: @MickLesk

Base: mainHead: seelf


📝 Commits (4)

📊 Changes

2 files changed (+30 additions, -56 deletions)

View changed files

📝 ct/seelf.sh (+24 -42)
📝 install/seelf-install.sh (+6 -14)

📄 Description

✍️ Description

  • Refactored the script and updated to use latest tools.func functions
  • Bugfixes

Link: #4949

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/4954 **Author:** [@tremor021](https://github.com/tremor021) **Created:** 6/3/2025 **Status:** ✅ Merged **Merged:** 6/4/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `seelf` --- ### 📝 Commits (4) - [`983aff6`](https://github.com/community-scripts/ProxmoxVE/commit/983aff637d21f4d9cbfa80872fa5d31691a20043) Refactor seelf - [`0005b01`](https://github.com/community-scripts/ProxmoxVE/commit/0005b01051555a5a05d083f740d217bd302dad00) Update - [`2da1dd7`](https://github.com/community-scripts/ProxmoxVE/commit/2da1dd7ca30f83c2a588dde83e3c7dfa4b0d68d9) Update - [`cbe94ad`](https://github.com/community-scripts/ProxmoxVE/commit/cbe94ad729f07d76ac4d892ecdd6dbb7f21019c4) Update ### 📊 Changes **2 files changed** (+30 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `ct/seelf.sh` (+24 -42) 📝 `install/seelf-install.sh` (+6 -14) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description - Refactored the script and updated to use latest `tools.func` functions - Bugfixes ## 🔗 Related PR / Issue Link: #4949 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [x] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 14:33:27 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#5213
No description provided.