starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 09:15:59 +03:00

[PR #4864] [CLOSED] Update add-tailscale-lxc.sh #5155

New issue

Closed

opened 2026-02-26 14:33:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 14:33:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/4864
Author: @bwinterfp
Created: 5/31/2025
Status: ❌ Closed

Base: main ← Head: brantwinterfp-patch-1

📝 Commits (1)

d71a31e Update add-tailscale-lxc.sh

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 tools/addon/add-tailscale-lxc.sh (+1 -1)

📄 Description

Replaced curl call with equivalent wget command as latest Debian 12 LXC template (debian-12-standard_12.7-1_amd64.tar.zst) available on PVE 8.4.1 does not ship with curl.

✍️ Description

curl command is failing when using latest debian-12-standard_12.7-1_amd64.tar.zst LXC template on PVE 8.4.1. This PR replaces curl with an equivalent wget call. Tested on a new LXC build.

Tested by removing old .gpg keyring and running apt update and getting the expected failure. Then ran wget command and again ran apt update with success:

root@tailscale01:~# rm /usr/share/keyrings/tailscale-archive-keyring.gpg
root@tailscale01:~#
root@tailscale01:~# apt update
Hit:1 http://deb.debian.org/debian bookworm InRelease
Hit:2 http://security.debian.org bookworm-security InRelease
Hit:3 http://deb.debian.org/debian bookworm-updates InRelease
Get:4 https://pkgs.tailscale.com/stable/debian bookworm InRelease
Err:4 https://pkgs.tailscale.com/stable/debian bookworm InRelease
  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 458CA832957F5868
Fetched 6581 B in 1s (6429 B/s)
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
72 packages can be upgraded. Run 'apt list --upgradable' to see them.
W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: https://pkgs.tailscale.com/stable/debian bookworm InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 458CA832957F5868
W: Failed to fetch https://pkgs.tailscale.com/stable/debian/dists/bookworm/InRelease  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 458CA832957F5868
W: Some index files failed to download. They have been ignored, or old ones used instead.
root@tailscale01:~#
root@tailscale01:~#
root@tailscale01:~# wget -q -O - --no-check-certificate https://pkgs.tailscale.com/stable/$ID/$VER.noarmor.gpg | tee /usr/share/keyrings/tailscale-archive-keyring.gpg >/dev/null
root@tailscale01:~# apt update
Hit:1 http://security.debian.org bookworm-security InRelease
Hit:2 http://deb.debian.org/debian bookworm InRelease
Hit:3 http://deb.debian.org/debian bookworm-updates InRelease
Get:4 https://pkgs.tailscale.com/stable/debian bookworm InRelease
Fetched 6581 B in 1s (6701 B/s)
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
72 packages can be upgraded. Run 'apt list --upgradable' to see them.
root@tailscale01:~#

All templates come with wget so should be no issue moving forward.

Link: #

https://github.com/community-scripts/ProxmoxVE/issues/4863

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.
🆕 New script – A fully functional and tested script or script set.
🌍 Website update – Changes to website-related JSON files or metadata.
🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/4864 **Author:** [@bwinterfp](https://github.com/bwinterfp) **Created:** 5/31/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `brantwinterfp-patch-1` --- ### 📝 Commits (1) - [`d71a31e`](https://github.com/community-scripts/ProxmoxVE/commit/d71a31ee4263bfd5f6555b0cb2adf2c367cbafa2) Update add-tailscale-lxc.sh ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tools/addon/add-tailscale-lxc.sh` (+1 -1) </details> ### 📄 Description Replaced curl call with equivalent wget command as latest Debian 12 LXC template (debian-12-standard_12.7-1_amd64.tar.zst) available on PVE 8.4.1 does not ship with curl.  ## ✍️ Description curl command is failing when using latest debian-12-standard_12.7-1_amd64.tar.zst LXC template on PVE 8.4.1. This PR replaces curl with an equivalent wget call. Tested on a new LXC build. Tested by removing old .gpg keyring and running `apt update` and getting the expected failure. Then ran wget command and again ran `apt update` with success: ``` root@tailscale01:~# rm /usr/share/keyrings/tailscale-archive-keyring.gpg root@tailscale01:~# root@tailscale01:~# apt update Hit:1 http://deb.debian.org/debian bookworm InRelease Hit:2 http://security.debian.org bookworm-security InRelease Hit:3 http://deb.debian.org/debian bookworm-updates InRelease Get:4 https://pkgs.tailscale.com/stable/debian bookworm InRelease Err:4 https://pkgs.tailscale.com/stable/debian bookworm InRelease The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 458CA832957F5868 Fetched 6581 B in 1s (6429 B/s) Reading package lists... Done Building dependency tree... Done Reading state information... Done 72 packages can be upgraded. Run 'apt list --upgradable' to see them. W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: https://pkgs.tailscale.com/stable/debian bookworm InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 458CA832957F5868 W: Failed to fetch https://pkgs.tailscale.com/stable/debian/dists/bookworm/InRelease The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 458CA832957F5868 W: Some index files failed to download. They have been ignored, or old ones used instead. root@tailscale01:~# root@tailscale01:~# root@tailscale01:~# wget -q -O - --no-check-certificate https://pkgs.tailscale.com/stable/$ID/$VER.noarmor.gpg | tee /usr/share/keyrings/tailscale-archive-keyring.gpg >/dev/null root@tailscale01:~# apt update Hit:1 http://security.debian.org bookworm-security InRelease Hit:2 http://deb.debian.org/debian bookworm InRelease Hit:3 http://deb.debian.org/debian bookworm-updates InRelease Get:4 https://pkgs.tailscale.com/stable/debian bookworm InRelease Fetched 6581 B in 1s (6701 B/s) Reading package lists... Done Building dependency tree... Done Reading state information... Done 72 packages can be upgraded. Run 'apt list --upgradable' to see them. root@tailscale01:~# ``` All templates come with wget so should be no issue moving forward. ## 🔗 Related PR / Issue Link: # https://github.com/community-scripts/ProxmoxVE/issues/4863 ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [X] **Tested thoroughly** – Changes work as expected. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [X] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 14:33:16 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 14:33:51 +03:00

[PR #5155] [MERGED] Intel NIC offload Fix by @rcastley #5344

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#5155

No description provided.

Rows
Columns