[PR #4846] [CLOSED] Improve Code Structure, Image Optimization, and Responsive Design #5150

Closed
opened 2026-02-26 14:33:14 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/4846
Author: @jaainil
Created: 5/30/2025
Status: Closed

Base: mainHead: bugs


📝 Commits (2)

  • c6f7721 Update package dependencies in package.json and package-lock.json
  • 5026093 Refactor layout and component files for improved structure and performance

📊 Changes

8 files changed (+2462 additions, -2031 deletions)

View changed files

📝 frontend/package-lock.json (+2403 -1948)
📝 frontend/package.json (+2 -2)
📝 frontend/src/app/api/versions/route.ts (+12 -12)
📝 frontend/src/app/category-view/page.tsx (+7 -2)
📝 frontend/src/app/layout.tsx (+8 -7)
📝 frontend/src/components/theme-provider.tsx (+1 -2)
📝 frontend/src/components/ui/calendar.tsx (+22 -29)
📝 frontend/src/components/ui/particles.tsx (+7 -29)

📄 Description

  • Added viewport metadata in layout.tsx to improve responsive behavior
  • Replaced <img> tags with Next.js Image component in category-view/page.tsx for better image optimization
  • Cleaned up imports and formatting in theme-provider.tsx and calendar.tsx for consistency

✍️ Description

This refactor improves overall project structure, code readability, and performance. It ensures responsive design, optimizes image loading, across components.

Link: #

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/4846 **Author:** [@jaainil](https://github.com/jaainil) **Created:** 5/30/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bugs` --- ### 📝 Commits (2) - [`c6f7721`](https://github.com/community-scripts/ProxmoxVE/commit/c6f7721cc6590e4f44c4f9d8ef6674e20ba70953) Update package dependencies in package.json and package-lock.json - [`5026093`](https://github.com/community-scripts/ProxmoxVE/commit/5026093f7790fe1534f4c06e77bd1846240a55cb) Refactor layout and component files for improved structure and performance ### 📊 Changes **8 files changed** (+2462 additions, -2031 deletions) <details> <summary>View changed files</summary> 📝 `frontend/package-lock.json` (+2403 -1948) 📝 `frontend/package.json` (+2 -2) 📝 `frontend/src/app/api/versions/route.ts` (+12 -12) 📝 `frontend/src/app/category-view/page.tsx` (+7 -2) 📝 `frontend/src/app/layout.tsx` (+8 -7) 📝 `frontend/src/components/theme-provider.tsx` (+1 -2) 📝 `frontend/src/components/ui/calendar.tsx` (+22 -29) 📝 `frontend/src/components/ui/particles.tsx` (+7 -29) </details> ### 📄 Description * Added `viewport` metadata in `layout.tsx` to improve responsive behavior * Replaced `<img>` tags with Next.js `Image` component in `category-view/page.tsx` for better image optimization * Cleaned up imports and formatting in `theme-provider.tsx` and `calendar.tsx` for consistency <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description This refactor improves overall project structure, code readability, and performance. It ensures responsive design, optimizes image loading, across components. ## 🔗 Related PR / Issue Link: # ## ✅ Prerequisites (**X** in brackets) * [x] **Self-review completed** – Code follows project standards. * [x] **Tested thoroughly** – Changes work as expected. * [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) * [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. * [ ] ✨ **New feature** – Adds new, non-breaking functionality. * [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. * [ ] 🆕 **New script** – A fully functional and tested script or script set. * [x] 🌍 **Website update** – Changes to website-related JSON files or metadata. * [x] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. * [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 14:33:14 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#5150
No description provided.