starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 09:15:59 +03:00

[PR #4827] [CLOSED] fix: pulse script tar warnings and interactive prompts #5135

New issue

Closed

opened 2026-02-26 14:33:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 14:33:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/4827
Author: @rcourtman
Created: 5/29/2025
Status: ❌ Closed

Base: main ← Head: fix/pulse-tar-warnings-and-prompts

📝 Commits (1)

5cb2de6 fix: pulse script tar warnings and remove interactive prompts

📊 Changes

2 files changed (+12 additions, -21 deletions)

View changed files

📝 ct/pulse.sh (+1 -1)
📝 install/pulse-install.sh (+11 -20)

📄 Description

Summary

Fixes issues with the Pulse installation script and corrects the installation workflow to follow proper community script conventions.

Changes Made

Suppress tar warnings: Added 2>/dev/null to tar extraction commands to suppress harmless extended header warnings on macOS
Remove interactive prompts: Eliminated credential prompts during LXC creation (incorrect workflow)
Use existing .env.example: Release tarball already includes detailed .env.example with comprehensive configuration options
Update systemd service: Use optional EnvironmentFile with - prefix so service can be enabled without .env file
Add post-install instructions: Clear guidance on how to configure Pulse after LXC creation

Issues Fixed

Users seeing confusing tar warnings about LIBARCHIVE.xattr.com.apple.provenance
Script incorrectly prompting for Proxmox credentials during LXC creation

Correct Workflow

The proper workflow is now:

Community script creates LXC and installs Pulse (with detailed .env.example already included)
User enters LXC and manually copies .env.example to .env
User edits .env file with their Proxmox credentials using the detailed examples/comments
User starts the pulse-monitor service when ready

Benefits

Users get the full detailed .env.example from the release with all configuration options and helpful comments
No interactive prompts during automated LXC creation
Follows standard community script patterns
Service is enabled but not started until user completes configuration

Test Plan

Verified tar extraction works without warnings
Confirmed LXC creation completes without prompts
Verified detailed .env.example is included from release tarball
Tested service can be enabled without .env file present

Files Changed

ct/pulse.sh - Added stderr redirection for tar command
install/pulse-install.sh - Removed interactive prompts, use existing .env.example, updated service config

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/4827 **Author:** [@rcourtman](https://github.com/rcourtman) **Created:** 5/29/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/pulse-tar-warnings-and-prompts` --- ### 📝 Commits (1) - [`5cb2de6`](https://github.com/community-scripts/ProxmoxVE/commit/5cb2de61af3d024858d1bcba4a203cdae9f5f6aa) fix: pulse script tar warnings and remove interactive prompts ### 📊 Changes **2 files changed** (+12 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `ct/pulse.sh` (+1 -1) 📝 `install/pulse-install.sh` (+11 -20) </details> ### 📄 Description ## Summary Fixes issues with the Pulse installation script and corrects the installation workflow to follow proper community script conventions. ## Changes Made - **Suppress tar warnings**: Added `2>/dev/null` to tar extraction commands to suppress harmless extended header warnings on macOS - **Remove interactive prompts**: Eliminated credential prompts during LXC creation (incorrect workflow) - **Use existing .env.example**: Release tarball already includes detailed .env.example with comprehensive configuration options - **Update systemd service**: Use optional EnvironmentFile with `-` prefix so service can be enabled without .env file - **Add post-install instructions**: Clear guidance on how to configure Pulse after LXC creation ## Issues Fixed 1. Users seeing confusing tar warnings about `LIBARCHIVE.xattr.com.apple.provenance` 2. Script incorrectly prompting for Proxmox credentials during LXC creation ## Correct Workflow The proper workflow is now: 1. Community script creates LXC and installs Pulse (with detailed .env.example already included) 2. User enters LXC and manually copies `.env.example` to `.env` 3. User edits `.env` file with their Proxmox credentials using the detailed examples/comments 4. User starts the pulse-monitor service when ready ## Benefits - Users get the full detailed `.env.example` from the release with all configuration options and helpful comments - No interactive prompts during automated LXC creation - Follows standard community script patterns - Service is enabled but not started until user completes configuration ## Test Plan - [x] Verified tar extraction works without warnings - [x] Confirmed LXC creation completes without prompts - [x] Verified detailed .env.example is included from release tarball - [x] Tested service can be enabled without .env file present ## Files Changed - `ct/pulse.sh` - Added stderr redirection for tar command - `install/pulse-install.sh` - Removed interactive prompts, use existing .env.example, updated service config 🤖 Generated with [Claude Code](https://claude.ai/code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 14:33:11 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#5135

No description provided.

Rows
Columns