[PR #4406] [MERGED] Navidrome - Fix config path (use /etc/ instead of /var/lib) #4848

Closed
opened 2026-02-26 14:32:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/4406
Author: @quake1508
Created: 5/12/2025
Status: Merged
Merged: 5/12/2025
Merged by: @michelroegl-brunner

Base: mainHead: quake1508-patch-1


📝 Commits (2)

  • 2538114 Fix config path for Navidrome (use /etc/ instead of /var/lib)
  • 9e8d923 Update navidrome.json - forgot "config_path"

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 frontend/public/json/navidrome.json (+2 -2)

📄 Description

The default systemd service for Navidrome loads the config from /etc/navidrome/navidrome.toml using the -c option. Therefore, edits to /var/lib/navidrome/navidrome.toml will not apply unless this path is manually set.

This PR updates the web UI JSON entry to reflect the correct config file path.

Thanks for the great scripts!

✍️ Description

Fixes misleading config path in the Navidrome JSON metadata shown on the website.
This improves clarity for users editing their container config.

Link: none

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/4406 **Author:** [@quake1508](https://github.com/quake1508) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/12/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `quake1508-patch-1` --- ### 📝 Commits (2) - [`2538114`](https://github.com/community-scripts/ProxmoxVE/commit/253811446d15c9174dd864baea0c1c381456fd80) Fix config path for Navidrome (use /etc/ instead of /var/lib) - [`9e8d923`](https://github.com/community-scripts/ProxmoxVE/commit/9e8d92318b7b6800188ca6dfecb471a3186f63e8) Update navidrome.json - forgot "config_path" ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/public/json/navidrome.json` (+2 -2) </details> ### 📄 Description The default systemd service for Navidrome loads the config from /etc/navidrome/navidrome.toml using the -c option. Therefore, edits to /var/lib/navidrome/navidrome.toml will not apply unless this path is manually set. This PR updates the web UI JSON entry to reflect the correct config file path. Thanks for the great scripts! ## ✍️ Description Fixes misleading config path in the Navidrome JSON metadata shown on the website. This improves clarity for users editing their container config. ## 🔗 Related PR / Issue Link: *none* ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [x] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 14:32:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#4848
No description provided.