[PR #3921] [MERGED] fix minor grammatical error in several scripts #4595

Closed
opened 2026-02-26 14:31:29 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/3921
Author: @jordanpatton
Created: 4/17/2025
Status: Merged
Merged: 4/17/2025
Merged by: @tremor021

Base: mainHead: jordanpatton-grammar-1


📝 Commits (1)

  • 350dbba updated word order in several scripts

📊 Changes

16 files changed (+16 additions, -16 deletions)

View changed files

📝 ct/create_lxc.sh (+1 -1)
📝 tools/addon/all-templates.sh (+1 -1)
📝 turnkey/turnkey.sh (+1 -1)
📝 vm/archlinux-vm.sh (+1 -1)
📝 vm/debian-vm.sh (+1 -1)
📝 vm/docker-vm.sh (+1 -1)
📝 vm/haos-vm.sh (+1 -1)
📝 vm/mikrotik-routeros.sh (+1 -1)
📝 vm/nextcloud-vm.sh (+1 -1)
📝 vm/openwrt.sh (+1 -1)
📝 vm/opnsense-vm.sh (+1 -1)
📝 vm/owncloud-vm.sh (+1 -1)
📝 vm/pimox-haos-vm.sh (+1 -1)
📝 vm/ubuntu2204-vm.sh (+1 -1)
📝 vm/ubuntu2404-vm.sh (+1 -1)
📝 vm/ubuntu2410-vm.sh (+1 -1)

📄 Description

✍️ Description

Updated several scripts that currently say "Which storage pool you would like to use..." to instead say "Which storage pool would you like to use...". (Apologies if I'm doing this incorrectly. Most of the affected scripts do not exist on ProxmoxVED, so as far as I can tell, I must submit the change here.)

N/A

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/3921 **Author:** [@jordanpatton](https://github.com/jordanpatton) **Created:** 4/17/2025 **Status:** ✅ Merged **Merged:** 4/17/2025 **Merged by:** [@tremor021](https://github.com/tremor021) **Base:** `main` ← **Head:** `jordanpatton-grammar-1` --- ### 📝 Commits (1) - [`350dbba`](https://github.com/community-scripts/ProxmoxVE/commit/350dbbad0524d2faf845445b6b99f5f633dabd24) updated word order in several scripts ### 📊 Changes **16 files changed** (+16 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `ct/create_lxc.sh` (+1 -1) 📝 `tools/addon/all-templates.sh` (+1 -1) 📝 `turnkey/turnkey.sh` (+1 -1) 📝 `vm/archlinux-vm.sh` (+1 -1) 📝 `vm/debian-vm.sh` (+1 -1) 📝 `vm/docker-vm.sh` (+1 -1) 📝 `vm/haos-vm.sh` (+1 -1) 📝 `vm/mikrotik-routeros.sh` (+1 -1) 📝 `vm/nextcloud-vm.sh` (+1 -1) 📝 `vm/openwrt.sh` (+1 -1) 📝 `vm/opnsense-vm.sh` (+1 -1) 📝 `vm/owncloud-vm.sh` (+1 -1) 📝 `vm/pimox-haos-vm.sh` (+1 -1) 📝 `vm/ubuntu2204-vm.sh` (+1 -1) 📝 `vm/ubuntu2404-vm.sh` (+1 -1) 📝 `vm/ubuntu2410-vm.sh` (+1 -1) </details> ### 📄 Description ## ✍️ Description Updated several scripts that currently say "Which storage pool **you would** like to use..." to instead say "Which storage pool **would you** like to use...". (Apologies if I'm [doing this incorrectly](https://github.com/community-scripts/ProxmoxVE/blob/main/.github/CONTRIBUTOR_AND_GUIDES/CONTRIBUTING.md). Most of the affected scripts do not exist on `ProxmoxVED`, so as far as I can tell, I must submit the change here.) ## 🔗 Related PR / Issue N/A ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 14:31:29 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#4595
No description provided.