[PR #3885] [MERGED] Omada: Increase RAM to 3GB and little improvements #4583

Closed
opened 2026-02-26 14:31:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/3885
Author: @MickLesk
Created: 4/14/2025
Status: Merged
Merged: 4/14/2025
Merged by: @michelroegl-brunner

Base: mainHead: MickLesk-patch-1


📝 Commits (4)

📊 Changes

3 files changed (+23 additions, -26 deletions)

View changed files

📝 ct/omada.sh (+11 -10)
📝 frontend/public/json/omada.json (+2 -2)
📝 install/omada-install.sh (+10 -14)

📄 Description

✍️ Description

little improvements on the script (readabillity)
increase RAM to 3GB (MongoDB is hungry 😄)

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines

📋 Additional Information (optional)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/3885 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 4/14/2025 **Status:** ✅ Merged **Merged:** 4/14/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `MickLesk-patch-1` --- ### 📝 Commits (4) - [`6ed926c`](https://github.com/community-scripts/ProxmoxVE/commit/6ed926c8abab7065b53e1ef9bbd56617fb24ae56) omada_hotfix - [`cc46239`](https://github.com/community-scripts/ProxmoxVE/commit/cc46239c2bf82a48da7e2b1bd8864b5ca54cb1f3) change function - [`1b65482`](https://github.com/community-scripts/ProxmoxVE/commit/1b6548265ab8cfa4da5df3d9491eb0871b38dccf) Omada: Small Changes & Increase RAM to 3GB - [`3c3c405`](https://github.com/community-scripts/ProxmoxVE/commit/3c3c40501fbe4a1d782abd993afc4cbb7a847eed) Update omada-install.sh ### 📊 Changes **3 files changed** (+23 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `ct/omada.sh` (+11 -10) 📝 `frontend/public/json/omada.json` (+2 -2) 📝 `install/omada-install.sh` (+10 -14) </details> ### 📄 Description ## ✍️ Description little improvements on the script (readabillity) increase RAM to 3GB (MongoDB is hungry :smile:) ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No breaking changes** – Existing functionality remains intact. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [x] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [x] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [ ] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** ## 📋 Additional Information (optional) <!-- Add any extra context, screenshots, or references. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 14:31:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#4583
No description provided.