starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 09:15:59 +03:00

[PR #3841] [CLOSED] Fix version check for build.func #4558

New issue

Closed

opened 2026-02-26 14:31:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 14:31:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/3841
Author: @MonishKrishna2009
Created: 4/11/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (1)

b9f5ba3 Fix version check for build.func

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 misc/build.func (+1 -1)

📄 Description

✍️ Description

Fixed a bug in the pve_check() function where the Proxmox VE Helper Script incorrectly reported newer versions (e.g., 8.4.0) as outdated. Updated the version check logic to properly handle numeric comparisons and ensure compatibility with Proxmox VE version 8.1 or later.

✅ Prerequisites (X in brackets)

[ X] Self-review completed – Code follows project standards.
[X ] Tested thoroughly – Changes work as expected.
[X ] No breaking changes – Existing functionality remains intact.
[X ] No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

[X ] 🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.
🆕 New script – A fully functional and tested script or script set.
🌍 Website update – Changes to website-related JSON files or metadata.
🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

[ X] Follows Code_Audit.md & CONTRIBUTING.md guidelines

📋 Additional Information (optional)

The issue was caused by incorrect version comparison logic in the pve_check() function, which relied on a regular expression that did not properly handle numeric comparisons for versions like 8.4.0.
The updated regex ensures compatibility with all Proxmox VE versions 8.1 and later, including patch versions and multi-digit minor versions (e.g., 8.10.0).
Thorough testing was performed on various Proxmox VE versions to confirm the fix.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/3841 **Author:** [@MonishKrishna2009](https://github.com/MonishKrishna2009) **Created:** 4/11/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`b9f5ba3`](https://github.com/community-scripts/ProxmoxVE/commit/b9f5ba380d5383b1587c94a04120e108a479dff5) Fix version check for build.func ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+1 -1) </details> ### 📄 Description ## ✍️ Description Fixed a bug in the `pve_check()` function where the Proxmox VE Helper Script incorrectly reported newer versions (e.g., 8.4.0) as outdated. Updated the version check logic to properly handle numeric comparisons and ensure compatibility with Proxmox VE version 8.1 or later. ## ✅ Prerequisites (**X** in brackets) - [ X] **Self-review completed** – Code follows project standards. - [X ] **Tested thoroughly** – Changes work as expected. - [X ] **No breaking changes** – Existing functionality remains intact. - [X ] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [X ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [ X] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** ## 📋 Additional Information (optional)  - The issue was caused by incorrect version comparison logic in the `pve_check()` function, which relied on a regular expression that did not properly handle numeric comparisons for versions like 8.4.0. - The updated regex ensures compatibility with all Proxmox VE versions 8.1 and later, including patch versions and multi-digit minor versions (e.g., 8.10.0). - Thorough testing was performed on various Proxmox VE versions to confirm the fix. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 14:31:22 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 14:32:38 +03:00

[PR #4570] [MERGED] Fix Dashy Config Path on Frontend #4962

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#4558

No description provided.

Rows
Columns