[PR #3564] [MERGED] Fixes and standard enforcement #4408

Closed
opened 2026-02-26 14:30:53 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/3564
Author: @tremor021
Created: 4/1/2025
Status: Merged
Merged: 4/1/2025
Merged by: @MickLesk

Base: mainHead: fixes


📝 Commits (10+)

  • 03a5c9e Fixes and standard enforcement
  • b656c1b Update
  • 4503867 Update
  • da01ee4 Update install/navidrome-install.sh
  • 3a9a44f Update install/ntfy-install.sh
  • b990924 Update install/nzbget-install.sh
  • 701e775 Update install/n8n-install.sh
  • 60b5af8 Update install/openhab-install.sh
  • 5028d7b Update install/paperless-ai-install.sh
  • 83bf59d Update install/pairdrop-install.sh

📊 Changes

81 files changed (+126 additions, -125 deletions)

View changed files

📝 .github/CONTRIBUTOR_AND_GUIDES/install/AppName-install.sh (+1 -1)
📝 ct/homeassistant.sh (+1 -1)
📝 ct/podman-homeassistant.sh (+1 -1)
📝 ct/watchyourlan.sh (+1 -1)
📝 install/adguard-install.sh (+1 -1)
📝 install/adventurelog-install.sh (+2 -2)
📝 install/agentdvr-install.sh (+1 -1)
📝 install/archivebox-install.sh (+1 -1)
📝 install/aria2-install.sh (+1 -1)
📝 install/beszel-install.sh (+1 -1)
📝 install/calibre-web-install.sh (+1 -1)
📝 install/cloudflared-install.sh (+1 -1)
📝 install/commafeed-install.sh (+1 -1)
📝 install/cosmos-install.sh (+1 -1)
📝 install/dotnetaspwebapi-install.sh (+1 -1)
📝 install/esphome-install.sh (+1 -1)
📝 install/evcc-install.sh (+1 -1)
📝 install/fileflows-install.sh (+1 -1)
📝 install/flaresolverr-install.sh (+1 -1)
📝 install/flowiseai-install.sh (+1 -1)

...and 61 more files

📄 Description

✍️ Description

Quick pass with fixes and standard enforcement

Link: #

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines

📋 Additional Information (optional)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/3564 **Author:** [@tremor021](https://github.com/tremor021) **Created:** 4/1/2025 **Status:** ✅ Merged **Merged:** 4/1/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `fixes` --- ### 📝 Commits (10+) - [`03a5c9e`](https://github.com/community-scripts/ProxmoxVE/commit/03a5c9eed3eab2a62a0932b410800db890886d6e) Fixes and standard enforcement - [`b656c1b`](https://github.com/community-scripts/ProxmoxVE/commit/b656c1bd1e3de1b657c1964ebfbde3c4462a2485) Update - [`4503867`](https://github.com/community-scripts/ProxmoxVE/commit/4503867451d73008514799ca4d012611779c3715) Update - [`da01ee4`](https://github.com/community-scripts/ProxmoxVE/commit/da01ee4b9719a6a9c0a4ca4e3cea546249bbba02) Update install/navidrome-install.sh - [`3a9a44f`](https://github.com/community-scripts/ProxmoxVE/commit/3a9a44f541da81bc1cf0da663792c8d7d7d6ed2d) Update install/ntfy-install.sh - [`b990924`](https://github.com/community-scripts/ProxmoxVE/commit/b990924cb0e2af93f8f4ead968f3e681bfa7d563) Update install/nzbget-install.sh - [`701e775`](https://github.com/community-scripts/ProxmoxVE/commit/701e7752ddbe94ddc4a0cb4ae900214bbe3b6a50) Update install/n8n-install.sh - [`60b5af8`](https://github.com/community-scripts/ProxmoxVE/commit/60b5af858068b25d574f5f2459ddca1dc19fd80f) Update install/openhab-install.sh - [`5028d7b`](https://github.com/community-scripts/ProxmoxVE/commit/5028d7bde150ef8479883eed647e770aaf52f1ce) Update install/paperless-ai-install.sh - [`83bf59d`](https://github.com/community-scripts/ProxmoxVE/commit/83bf59d8f4bc59620d3d1b9e73247793110018ef) Update install/pairdrop-install.sh ### 📊 Changes **81 files changed** (+126 additions, -125 deletions) <details> <summary>View changed files</summary> 📝 `.github/CONTRIBUTOR_AND_GUIDES/install/AppName-install.sh` (+1 -1) 📝 `ct/homeassistant.sh` (+1 -1) 📝 `ct/podman-homeassistant.sh` (+1 -1) 📝 `ct/watchyourlan.sh` (+1 -1) 📝 `install/adguard-install.sh` (+1 -1) 📝 `install/adventurelog-install.sh` (+2 -2) 📝 `install/agentdvr-install.sh` (+1 -1) 📝 `install/archivebox-install.sh` (+1 -1) 📝 `install/aria2-install.sh` (+1 -1) 📝 `install/beszel-install.sh` (+1 -1) 📝 `install/calibre-web-install.sh` (+1 -1) 📝 `install/cloudflared-install.sh` (+1 -1) 📝 `install/commafeed-install.sh` (+1 -1) 📝 `install/cosmos-install.sh` (+1 -1) 📝 `install/dotnetaspwebapi-install.sh` (+1 -1) 📝 `install/esphome-install.sh` (+1 -1) 📝 `install/evcc-install.sh` (+1 -1) 📝 `install/fileflows-install.sh` (+1 -1) 📝 `install/flaresolverr-install.sh` (+1 -1) 📝 `install/flowiseai-install.sh` (+1 -1) _...and 61 more files_ </details> ### 📄 Description <!--🛑 New scripts must first be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs for new scripts that skip this process will be closed. --> ## ✍️ Description <!-- Briefly describe your changes. --> Quick pass with fixes and standard enforcement ## 🔗 Related PR / Issue Link: # ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [ ] **Tested thoroughly** – Changes work as expected. - [x] **No breaking changes** – Existing functionality remains intact. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [x] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [x] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** ## 📋 Additional Information (optional) <!-- Add any extra context, screenshots, or references. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 14:30:53 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#4408
No description provided.