[PR #3318] [MERGED] Omada zulu 8 to 21 #4268

Closed
opened 2026-02-26 13:36:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/3318
Author: @bvdberg01
Created: 3/21/2025
Status: Merged
Merged: 3/21/2025
Merged by: @CrazyWolf13

Base: mainHead: fix-omada


📝 Commits (2)

📊 Changes

2 files changed (+13 additions, -2 deletions)

View changed files

📝 ct/omada.sh (+12 -1)
📝 install/omada-install.sh (+1 -1)

📄 Description

✍️ Description

Zulu8-jdk to Zulu21-jdk
Made dpkg non interactive and silent (because it gives popup that it is recommended to create backup)

Link: #3309

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines

📋 Additional Information (optional)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/3318 **Author:** [@bvdberg01](https://github.com/bvdberg01) **Created:** 3/21/2025 **Status:** ✅ Merged **Merged:** 3/21/2025 **Merged by:** [@CrazyWolf13](https://github.com/CrazyWolf13) **Base:** `main` ← **Head:** `fix-omada` --- ### 📝 Commits (2) - [`349869c`](https://github.com/community-scripts/ProxmoxVE/commit/349869cda1aa69355fec8f40c6603be2662f38a8) change zulu8 to zulu21 - [`53b05f9`](https://github.com/community-scripts/ProxmoxVE/commit/53b05f93f4de42ac571890f78ddb4bca5a2f8961) Add check in updatescript ### 📊 Changes **2 files changed** (+13 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `ct/omada.sh` (+12 -1) 📝 `install/omada-install.sh` (+1 -1) </details> ### 📄 Description ## ✍️ Description Zulu8-jdk to Zulu21-jdk Made dpkg non interactive and silent (because it gives popup that it is recommended to create backup) ## 🔗 Related PR / Issue Link: #3309 ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [X] **Tested thoroughly** – Changes work as expected. - [X] **No breaking changes** – Existing functionality remains intact. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [X] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [ ] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** ## 📋 Additional Information (optional) <!-- Add any extra context, screenshots, or references. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 13:36:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#4268
No description provided.