[PR #3092] [MERGED] Homepage: Bugfix for v1.0.0 #4129

Closed
opened 2026-02-26 13:35:46 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/3092
Author: @vhsdream
Created: 3/15/2025
Status: Merged
Merged: 3/15/2025
Merged by: @MickLesk

Base: mainHead: homepage-fix


📝 Commits (2)

📊 Changes

3 files changed (+20 additions, -8 deletions)

View changed files

📝 ct/homepage.sh (+7 -2)
📝 install/homepage-install.sh (+7 -4)
📝 json/homepage.json (+6 -2)

📄 Description

✍️ Description

This PR does the following:

In homepage-install.sh

  • Cleans up the dependency install command
  • adds an export to disable NextJS telemetry
  • adds the LOCAL_IP var
  • creates the /opt/homepage/.env file with correct environment variable, using LOCAL_IP
    • Users may still have to add more hostnames/IP addresses, depending on setup

In homepage.sh

  • Increases RAM and disk for Homepage
  • Checks for the /opt/homepage/.env file - if absent, creates it with the env var
  • Disables telemetry

In homepage.json

  • Changed default settings for install, increasing RAM and disk resources
  • Added a note about the new .env file

Fixes #3083

Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

  • [] 🆕 New script – A fully functional and tested script or script set.
  • [] 🐞 Bug fix – Resolves an issue without breaking functionality.
  • [] New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.

📋 Additional Information (optional)

Although this will add localhost:3000,<local_ip>:3000 to the .env file, users may still need to add more hostnames/IP addresses in order for their Homepage to work. I had to add my domain name since I run it behind a reverse proxy with TLS even though it's not exposed externally.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/3092 **Author:** [@vhsdream](https://github.com/vhsdream) **Created:** 3/15/2025 **Status:** ✅ Merged **Merged:** 3/15/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `homepage-fix` --- ### 📝 Commits (2) - [`22a3764`](https://github.com/community-scripts/ProxmoxVE/commit/22a376478794325086813836df0213078b946d0d) (for revert)modify func files - [`5a94f6e`](https://github.com/community-scripts/ProxmoxVE/commit/5a94f6e2757e9d29c2fbb8edeb4b8913a212fc1b) KSS ### 📊 Changes **3 files changed** (+20 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `ct/homepage.sh` (+7 -2) 📝 `install/homepage-install.sh` (+7 -4) 📝 `json/homepage.json` (+6 -2) </details> ### 📄 Description ## ✍️ Description This PR does the following: ### In homepage-install.sh - Cleans up the dependency install command - adds an export to disable NextJS telemetry - adds the LOCAL_IP var - creates the `/opt/homepage/.env` file with correct environment variable, using LOCAL_IP - Users may still have to add more hostnames/IP addresses, depending on setup ### In homepage.sh - Increases RAM and disk for Homepage - Checks for the `/opt/homepage/.env` file - if absent, creates it with the env var - Disables telemetry ### In homepage.json - Changed default settings for install, increasing RAM and disk resources - Added a note about the new `.env` file ## 🔗 Related PR / Discussion / Issue Fixes #3083 ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [x] **Self-review performed** – Code follows established patterns and conventions. - [x] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [] 🆕 **New script** – A fully functional and tested script or script set. - [] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [] ✨ **New feature** – Adds new, non-breaking functionality. - [X] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. ## 📋 Additional Information (optional) Although this will add `localhost:3000,<local_ip>:3000` to the .env file, users may still need to add more hostnames/IP addresses in order for their Homepage to work. I had to add my domain name since I run it behind a reverse proxy with TLS even though it's not exposed externally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 13:35:46 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#4129
No description provided.