[PR #2592] [MERGED] Feature: Template-Check, Better Handling of Downloads, Better Network… #3849

New issue

Closed

opened 2026-02-26 13:34:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:34:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2592
Author: @MickLesk
Created: 2/24/2025
Status: ✅ Merged
Merged: 2/24/2025
Merged by: @MickLesk

Base: main ← Head: feature_templatectid_check

📝 Commits (4)

a2a0fb7 Feature: Template-Check, Better Handling of Downloads, Better Network Check, Better CTID check
4a9b65d fix missing }
b16b1aa Update misc/build.func
8d1f27c remove useless space

📊 Changes

2 files changed (+112 additions, -47 deletions)

View changed files

📝 ct/create_lxc.sh (+98 -35)
📝 misc/build.func (+14 -12)

📄 Description

✍️ Description

Features:

Check if CTID used before (also in VM's)
Add an Network-Check for Template-Crawling before
Add an Attempt to check if template exists or corrupt, try again in 3 steps, if not - exit
Improve Api Logging
Formatting & Indention

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

Self-review performed – Code follows established patterns and conventions.
Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

✨ New feature – Adds new, non-breaking functionality.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2592 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 2/24/2025 **Status:** ✅ Merged **Merged:** 2/24/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `feature_templatectid_check` --- ### 📝 Commits (4) - [`a2a0fb7`](https://github.com/community-scripts/ProxmoxVE/commit/a2a0fb77d8f79a8472985f1d4d98ac63b62dcd27) Feature: Template-Check, Better Handling of Downloads, Better Network Check, Better CTID check - [`4a9b65d`](https://github.com/community-scripts/ProxmoxVE/commit/4a9b65db6b3951d7e2a84554ddfaa76b933880ad) fix missing } - [`b16b1aa`](https://github.com/community-scripts/ProxmoxVE/commit/b16b1aa39d7d3a286656e19bdec0f7c82829791d) Update misc/build.func - [`8d1f27c`](https://github.com/community-scripts/ProxmoxVE/commit/8d1f27c85f68ac501826b2800d047fca5a2b5391) remove useless space ### 📊 Changes **2 files changed** (+112 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `ct/create_lxc.sh` (+98 -35) 📝 `misc/build.func` (+14 -12) </details> ### 📄 Description ## ✍️ Description **Features:** - Check if CTID used before (also in VM's) - Add an Network-Check for Template-Crawling before - Add an Attempt to check if template exists or corrupt, try again in 3 steps, if not - exit - Improve Api Logging - Formatting & Indention ![image](https://github.com/user-attachments/assets/52877b63-ab2c-4730-bc49-8cdcabbbf9ab) ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [x] **Self-review performed** – Code follows established patterns and conventions. - [x] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change - [x] ✨ **New feature** – Adds new, non-breaking functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:34:51 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#3849

No description provided.

Rows
Columns