[PR #2586] [CLOSED] Feature: Robust Check if LXC-Template Exists & Check CTID before Creation #3843

New issue

Closed

opened 2026-02-26 13:34:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:34:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2586
Author: @MickLesk
Created: 2/24/2025
Status: ❌ Closed

Base: main ← Head: fix_ctid_creation

📝 Commits (5)

424fce7 Verbose_Update
f3b5217 Formatting
c1e5285 vm ct-id check
2f75b05 Recheck / Downloading Check
8ff59c9 Update create_lxc.sh

📊 Changes

4 files changed (+287 additions, -161 deletions)

View changed files

📝 ct/create_lxc.sh (+69 -37)
📝 misc/alpine-install.func (+31 -19)
📝 misc/build.func (+148 -78)
📝 misc/install.func (+39 -27)

📄 Description

✍️ Description

currently Draft, check it in my dev repo

Features:

Check if CTID used before (also in VM's)
Add an Attempt to check if template exists or corrupt, try again in 3 steps, if not - exit

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

Self-review performed – Code follows established patterns and conventions.
[] Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

✨ New feature – Adds new, non-breaking functionality.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2586 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 2/24/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix_ctid_creation` --- ### 📝 Commits (5) - [`424fce7`](https://github.com/community-scripts/ProxmoxVE/commit/424fce78e1ecfff711df4f7d579911720c9d9f2f) Verbose_Update - [`f3b5217`](https://github.com/community-scripts/ProxmoxVE/commit/f3b52170fe104309a88ad2e66b1a53c1b78ef6aa) Formatting - [`c1e5285`](https://github.com/community-scripts/ProxmoxVE/commit/c1e528550a9b28a4252ff7351f3ff1876ceaa2c0) vm ct-id check - [`2f75b05`](https://github.com/community-scripts/ProxmoxVE/commit/2f75b05dab638566aaa0b84da8027c06358a4eb6) Recheck / Downloading Check - [`8ff59c9`](https://github.com/community-scripts/ProxmoxVE/commit/8ff59c9639cd94231f2064ee61e0e544d83a8100) Update create_lxc.sh ### 📊 Changes **4 files changed** (+287 additions, -161 deletions) <details> <summary>View changed files</summary> 📝 `ct/create_lxc.sh` (+69 -37) 📝 `misc/alpine-install.func` (+31 -19) 📝 `misc/build.func` (+148 -78) 📝 `misc/install.func` (+39 -27) </details> ### 📄 Description ## ✍️ Description - currently Draft, check it in my dev repo Features: - Check if CTID used before (also in VM's) - Add an Attempt to check if template exists or corrupt, try again in 3 steps, if not - exit ![image](https://github.com/user-attachments/assets/9ce6b6a5-ddad-4fa3-8d04-48972c71bf34) ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [x] **Self-review performed** – Code follows established patterns and conventions. - [] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change - [x] ✨ **New feature** – Adds new, non-breaking functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:34:49 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#3843

No description provided.

Rows
Columns