starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 01:06:06 +03:00

[PR #2479] [CLOSED] Fix: PATH env and file handling in Watcharr Update Script #3789

New issue

Closed

opened 2026-02-26 13:34:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:34:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2479
Author: @Clusters
Created: 2/18/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (2)

e425adf Fix: PATH env in Watcharr Update Script
add05c4 Fix: file replacement in Watcharr Update Script

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 ct/watcharr.sh (+5 -3)

📄 Description

✍️ Description

I've found and fixed two small bugs inside the Watcharr update function.

golang binary was in /urs/local/bin, which wasn't present in PATH environment -> see #2478
command to replace new files over old files did not work

Fixes #2478

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

Self-review performed – Code follows established patterns and conventions.
Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

🐞 Bug fix – Resolves an issue without breaking functionality.
[] ✨ New feature – Adds new, non-breaking functionality.
[] 💥 Breaking change – Alters existing functionality in a way that may require updates.
[] 🆕 New script – A fully functional and tested script or script set.

📋 Additional Information (optional)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2479 **Author:** [@Clusters](https://github.com/Clusters) **Created:** 2/18/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`e425adf`](https://github.com/community-scripts/ProxmoxVE/commit/e425adffda9ab3b53f8f1e97e7150cfdaeb8283e) Fix: PATH env in Watcharr Update Script - [`add05c4`](https://github.com/community-scripts/ProxmoxVE/commit/add05c469d98e393b8c601d1a5b37374d72b5f17) Fix: file replacement in Watcharr Update Script ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `ct/watcharr.sh` (+5 -3) </details> ### 📄 Description ## ✍️ Description I've found and fixed two small bugs inside the Watcharr update function. 1. golang binary was in /urs/local/bin, which wasn't present in PATH environment -> see #2478 2. command to replace new files over old files did not work ## 🔗 Related PR / Discussion / Issue Fixes #2478 ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [x] **Self-review performed** – Code follows established patterns and conventions. - [x] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [] ✨ **New feature** – Adds new, non-breaking functionality. - [] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [] 🆕 **New script** – A fully functional and tested script or script set. ## 📋 Additional Information (optional) ![Screenshot 2025-02-18 200205](https://github.com/user-attachments/assets/0d26b776-f952-4996-b7b9-2765f54bedd8) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:34:39 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 14:31:16 +03:00

[PR #3789] [MERGED] [Github Action] Update CHANGELOG.md #4528

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#3789

No description provided.

Rows
Columns