starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 17:26:03 +03:00

[PR #2400] [MERGED] Script Format Check Workflow #3752

New issue

Closed

opened 2026-02-26 13:34:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:34:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2400
Author: @michelroegl-brunner
Created: 2/14/2025
Status: ✅ Merged
Merged: 2/28/2025
Merged by: @MickLesk

Base: main ← Head: format_workflow

📝 Commits (1)

24fe287 Shell Format Workflow

📊 Changes

1 file changed (+243 additions, -0 deletions)

View changed files

➕ .github/workflows/script_format.yml (+243 -0)

📄 Description

✍️ Description

This introduces a new Shell Format check to see if a few set standard lines are what we expect. If there are errors ther will be a comment with the offending Line and what should be there.

ADVISE: THIS WILL TRIGGER ON MANY SCRIPTS AT THE MOMENT
We as contributors would have to fix wrong formatted scripts either befor merge of this or when a PR with a Script comes up. This will be anyoing for a few weeks until the standards are met.

In theory we could just sed through the script and correct offending lines automaticaly, but i´m not sure if we really want that.

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

Self-review performed – Code follows established patterns and conventions.
Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

[] 🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
[] 💥 Breaking change – Alters existing functionality in a way that may require updates.
[] 🆕 New script – A fully functional and tested script or script set.

📋 Additional Information (optional)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2400 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 2/14/2025 **Status:** ✅ Merged **Merged:** 2/28/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `format_workflow` --- ### 📝 Commits (1) - [`24fe287`](https://github.com/community-scripts/ProxmoxVE/commit/24fe287917d4c3444c1d24ce79c1ac29013bb71d) Shell Format Workflow ### 📊 Changes **1 file changed** (+243 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/script_format.yml` (+243 -0) </details> ### 📄 Description ## ✍️ Description  This introduces a new Shell Format check to see if a few set standard lines are what we expect. If there are errors ther will be a comment with the offending Line and what should be there. __**ADVISE: THIS WILL TRIGGER ON MANY SCRIPTS AT THE MOMENT**__ We as contributors would have to fix wrong formatted scripts either befor merge of this or when a PR with a Script comes up. This will be anyoing for a few weeks until the standards are met. In theory we could just sed through the script and correct offending lines automaticaly, but i´m not sure if we really want that. ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [X] **Self-review performed** – Code follows established patterns and conventions. - [X] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [X] ✨ **New feature** – Adds new, non-breaking functionality. - [] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [] 🆕 **New script** – A fully functional and tested script or script set. ## 📋 Additional Information (optional)  ![image](https://github.com/user-attachments/assets/6ef32aaf-0496-463d-99a5-3f2447c955dc) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:34:32 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 14:31:12 +03:00

[PR #3752] [MERGED] [Github Action] Update CHANGELOG.md #4510

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#3752

No description provided.

Rows
Columns